Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Eli Zaretskii" <eliz@is.elta.co.il>
To: tromey@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: Patch: search `directory' path for `break' files
Date: Sat, 29 Sep 2001 02:45:00 -0000	[thread overview]
Message-ID: <4634-Sat29Sep2001114241+0300-eliz@is.elta.co.il> (raw)
In-Reply-To: <87r8sq6fa9.fsf@creche.redhat.com>

> From: Tom Tromey <tromey@redhat.com>
> Date: 28 Sep 2001 17:56:14 -0600
> 
> What I've done here is change lookup_symtab and lookup_partial_symtab
> to try to use the full path when looking up a file name.  This only
> works on systems with realpath(); it could probably be ported to other
> systems (or a portable realpath() implementation could be found).
> 
> With this patch, if the file name argument to lookup_symtab is a full
> path, we run it through realpath.  Then we search for each symtab's
> file using the `dir' list.  If we find a match, we use it.

IIRC, last time this was discussed, Per Bothner suggested to use the
current directory recorded in the debug info to convert a relative or
semi-relative file name into an absolute one.

Unless I'm mistaken, your patch doesn't do that.  Any particular
reason?  Per's suggestion did seem like the best solution to this.

> I built and tested this on x86 Red Hat Linux 6.2.  I ran make check
> against the cvs head and then again with this patch applied.

I think this needs to be tested with as many debug infor formats as
possible.  What format did you use? DWARF2?


  reply	other threads:[~2001-09-29  2:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-09-28 16:45 Tom Tromey
2001-09-29  2:45 ` Eli Zaretskii [this message]
2001-10-01 13:52   ` Tom Tromey
2001-10-01 15:35     ` Michael Snyder
2001-10-02  1:01     ` Eli Zaretskii
2001-10-11 12:50 ` Elena Zannoni
2001-10-11 20:46   ` Tom Tromey
2001-10-14 14:43     ` Elena Zannoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4634-Sat29Sep2001114241+0300-eliz@is.elta.co.il \
    --to=eliz@is.elta.co.il \
    --cc=gdb-patches@sources.redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox