From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8076 invoked by alias); 7 Jun 2002 13:55:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8067 invoked from network); 7 Jun 2002 13:55:08 -0000 Received: from unknown (HELO thor.inter.net.il) (192.114.186.11) by sources.redhat.com with SMTP; 7 Jun 2002 13:55:08 -0000 Received: from Zaretsky ([80.230.2.40]) by thor.inter.net.il (Mirapoint Messaging Server MOS 3.1.0.58-GA) with ESMTP id AHB79919; Fri, 7 Jun 2002 16:54:18 +0300 (IDT) Date: Fri, 07 Jun 2002 06:55:00 -0000 From: "Eli Zaretskii" To: george@gly.bris.ac.uk Message-Id: <4634-Fri07Jun2002165255+0300-eliz@is.elta.co.il> CC: gdb-patches@sources.redhat.com In-reply-to: <200206061710.SAA03206@xterm1.gly.bris.ac.uk> (george@gly.bris.ac.uk) Subject: Re: Proposed gdb patch Reply-to: Eli Zaretskii References: <200206061710.SAA03206@xterm1.gly.bris.ac.uk> X-SW-Source: 2002-06/txt/msg00107.txt.bz2 > Date: Thu, 6 Jun 2002 18:10:27 +0100 > From: "G. Helffrich" > > Following previous comments, here is an updated version of the > proposed patch to gdb 5.1.1 (28 May 2002) that adds functionality to the gdb > command language. It implements the "edit" command featured in the Sun and > SGI dbx, which invokes your favorite file editor on the active line of the > program being debugged. Thanks. > + add_com ("edit", class_files, edit_command, > + concat ("Edit specified file or function.\n\ > + With no argument, edits file containing most recent line listed.\n\ > + ", "\ > + Editing targets can be specified in these ways:\n\ > + FILE:LINENUM, to edit at that line in that file,\n\ > + FUNCTION, to edit at the beginning of that function,\n\ > + FILE:FUNCTION, to distinguish among like-named static functions.\n\ > + *ADDRESS, to edit at the line containing that address.\n\ > + Uses EDITOR environment variable contents as editor (or ex as default).",NULL)); I'd prefer that this command used the location_completer as its completion function, since the arguments it accepts are source code locations similar to the "break" command. > Index: gdb-5.1.1/src/gdb/doc/gdb.texinfo The docs changes are approved, but please fix the following minor problem: > + @node Edit > + @section Editing source files Please add here an index entry, for example: @cindex editing source files