From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112513 invoked by alias); 15 Mar 2019 12:34:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112445 invoked by uid 89); 15 Mar 2019 12:34:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=0.4 required=5.0 tests=AWL,BAYES_50,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*RU:sk:sonic31, HX-HELO:sk:sonic31, HX-Spam-Relays-External:sk:sonic31, H*r:sk:sonic31 X-HELO: sonic313-20.consmr.mail.ir2.yahoo.com Received: from sonic313-20.consmr.mail.ir2.yahoo.com (HELO sonic313-20.consmr.mail.ir2.yahoo.com) (77.238.179.187) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Mar 2019 12:34:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1552653289; bh=zB5Rat3rwhhBZ/GezHcsNWm52tOIIqpjjK7p105mRZM=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject; b=VD0Js+12uL8wAkZjJbz8m2FRAPGJNhpHZg+mldhZPYi+iDUANp1u6mFTfPh8u7JtzGhUXnUB6GMvW6/riP3H07knsCBDuLd+W3NqFsoH+E/y5jGh9/7U3P2e5j47P6ly53lPwhZMl4hVcF7P1AkHGsakLZYOZaFzUmXW+cjBthmxdni0yRvlA1AUtarwzZWhdhrURfEarleyZZP2Q6N3GtWRouzlFyqfXUUGaudDmkT6MuWzXacPVtuzbUdYqfG8MKKRdaDLEbHqFK67oq0yxQjtb6StuJuPgryaSuvyGmYdbNfA9QJpTmvO0AfkojPifsV2Oj8FnFmSOn15SQFAyA== Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ir2.yahoo.com with HTTP; Fri, 15 Mar 2019 12:34:49 +0000 Date: Fri, 15 Mar 2019 12:34:00 -0000 From: "Hannes Domani via gdb-patches" Reply-To: Hannes Domani To: GDB Patches Message-ID: <462860097.9024475.1552653278391@mail.yahoo.com> In-Reply-To: <5bb1d8b6-1ee9-3c2b-7a03-224657e2287f@redhat.com> References: <20190308210433.32683-1-tromey@adacore.com> <1828778750.3318305.1552141698307@mail.yahoo.com> <87o96g3upj.fsf@tromey.com> <375483967.6114402.1552410513314@mail.yahoo.com> <83lg1i3hkj.fsf@gnu.org> <5bb1d8b6-1ee9-3c2b-7a03-224657e2287f@redhat.com> Subject: Re: [PATCH] Fix scrolling right in the TUI (Re: [RFC 8.3 0/3] Some style fixes) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00308.txt.bz2 Am Donnerstag, 14. M=C3=A4rz 2019, 21:58:40 MEZ hat Pedro Alves Folgendes geschrieben:=20 > I agree.=C2=A0 Hannes, I've written a git commit log entry, as well > as a ChangeLog entry for you.=C2=A0 Please double-check whether > I didn't make some mistake. > > I've made one change in the patch, here: > > On 03/12/2019 05:08 PM, Hannes Domani via gdb-patches wrote: > > +=C2=A0 =C2=A0 =C2=A0 if (column <=3D first_col || column > first_col += line_width) > > +=C2=A0=C2=A0=C2=A0 { > > +=C2=A0=C2=A0=C2=A0 =C2=A0 if (c =3D=3D '\t') > > +=C2=A0=C2=A0=C2=A0 =C2=A0 =C2=A0 { > > +=C2=A0=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 int j, max_tab_len =3D tui_tab= _width; > > + > > +=C2=A0=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 --column; > > +=C2=A0=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 for (j =3D column % max_tab_le= n; > > +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0 j < max_tab_len && column= < first_col + line_width; > > +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0 column++, j++) > > +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 if (column >=3D first_col) > > +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0 result.push_back (' '); > > +=C2=A0=C2=A0=C2=A0 =C2=A0 =C2=A0 } > > +=C2=A0=C2=A0=C2=A0 =C2=A0 continue; > > +=C2=A0=C2=A0=C2=A0 } > > instead of duplicating that code, I'd put it in a lambda > and use it in both places. Since that duplicate code actually did bother me, I prefer your changes. And I just tested it, still works fine. Regards Hannes Domani