From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23380 invoked by alias); 18 Apr 2007 13:06:53 -0000 Received: (qmail 23370 invoked by uid 22791); 18 Apr 2007 13:06:52 -0000 X-Spam-Check-By: sourceware.org Received: from lon-del-03.spheriq.net (HELO lon-del-03.spheriq.net) (195.46.50.99) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 18 Apr 2007 14:06:49 +0100 Received: from lon-out-03.spheriq.net ([195.46.50.131]) by lon-del-03.spheriq.net with ESMTP id l3ID6kXs010191 for ; Wed, 18 Apr 2007 13:06:46 GMT Received: from lon-cus-02.spheriq.net (lon-cus-02.spheriq.net [195.46.50.38]) by lon-out-03.spheriq.net with ESMTP id l3ID6jRs026512 for ; Wed, 18 Apr 2007 13:06:45 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by lon-cus-02.spheriq.net with ESMTP id l3ID6hO1003053 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 18 Apr 2007 13:06:44 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 8E745DA45; Wed, 18 Apr 2007 13:06:39 +0000 (GMT) Received: from mail1.cro.st.com (mail1.cro.st.com [164.129.40.131]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 4D1FB4744D; Wed, 18 Apr 2007 13:06:39 +0000 (GMT) Received: from [164.129.44.95] (crx595.cro.st.com [164.129.44.95]) by mail1.cro.st.com (MOS 3.7.5a-GA) with ESMTP id CKG60355 (AUTH "denis pilat"); Wed, 18 Apr 2007 15:06:38 +0200 (CEST) Message-ID: <462617DE.907@st.com> Date: Wed, 18 Apr 2007 13:17:00 -0000 From: Denis PILAT User-Agent: Thunderbird 1.5.0.10 (X11/20070221) MIME-Version: 1.0 To: Daniel Jacobowitz , gdb-patches@sourceware.org Subject: Re: [RFC] DW_AT_type missing from DW_TAG_subrange_type References: <4612556C.1080709@st.com> <20070410153043.GC10890@caradoc.them.org> <46261453.1050102@st.com> <20070418130059.GA22170@caradoc.them.org> In-Reply-To: <20070418130059.GA22170@caradoc.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00283.txt.bz2 Daniel Jacobowitz wrote: > On Wed, Apr 18, 2007 at 02:51:31PM +0200, Denis PILAT wrote: > >> 2007-04-18 Denis Pilat >> >> * dwarf2read.c (read_subrange_type): Use of DW_ATE_signed default type >> when missing from DW_TAG_subrange_type. Remove the handling of null >> return from die_type(). >> > > This is OK with two small changes. First, the changelog entry should be: > > * dwarf2read.c (read_subrange_type): Use DW_ATE_signed default type > when missing from DW_TAG_subrange_type. Remove the handling of null > return from die_type. > > (Grammar fix, two spaces between sentences, no parentheses after the > name of a function - that's a recent change in the GNU standards, I > think) > > >> + base_type = dwarf_base_type (DW_ATE_signed, TARGET_ADDR_BIT /8, cu); >> > > And a space on each side of the "/". > > Thanks! > > Ok, that means I did a mistake in my previous ChangeLog entry about target_terminal_ours ? Can I change it as well in the same commit, removing "()" ? Denis