Re: [RFA] re-initialize height to 0 during setshow.exp

Denis PILAT
2007-04-03T13:26:52Z

Michael Snyder wrote:
> On Mon, 2007-04-02 at 16:57 +0200, Denis PILAT wrote:
>
>> In testsuite/gdb.base/setshow.exp, after "set height 100", it could
>> occur that following commands require user interaction to proceed like:
>> ---Type <return> to continue, or q <return> to quit---
>> (At least it's the case for our gdb in "show user" since we have defined
>> a lot of user command.)
>>
>> Attach is a patch that fixes a problem in this test.
>> We could also add
>> gdb_test "set height 0" "" "set height 0"
>> or increase the height to a very large number, but I prefer to reset
>> height to 0 like done in gdb.exp.
>>
>>
>
> I think it's valid, but I wonder why you didn't just use gdb_test,
> instead of gdb_expect? Are you expecting the command to fail or
> time out or something?
>
>
>
It just because gdb_test will add a new test, and I just want to fix a
problem.
But it would be much simpler to add *gdb_test "set height 0" "" "set
height 0"*
It was much RFC I should I put in my title,

Any more opinion ?
--
Denis