Re: Final(?) patch to update libtool in GCC and src trees

Ralf Wildenhues
2007-04-11T08:57:08Z

* Paolo Bonzini wrote on Wed, Apr 11, 2007 at 10:50:31AM CEST:
>>> I would rewrite them at the very least as
>>>
>>> AC_PROG_AWK
>>> AC_PROG_CXX
>>>
>>> if test "${use_libtool}" = "yes"; then
>>> AC_LIBTOOL_WIN32_DLL
>>> AM_PROG_LIBTOOL
>>> fi
>> I think that should use AS_IF instead.
>
> Does AS_IF put required macros outside its expansion? That's a
> cool feature if it does.

Only with Autoconf 2.60 and newer.

> However, if this is the case, it is also a problem.
> AM_PROG_LIBTOOL used to expand its subparts via
> AC_REQUIRE, which would sort of undo the effect of
> the if statement.

Yes, I don't think it'll help here. But also I don't see why CXX should
come into play here at all, if not by an old 1.5.x libtool.m4 file that
is picked up by aclocal (without having tested anything, though).

Cheers,
Ralf