From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11836 invoked by alias); 11 Apr 2007 08:51:08 -0000 Received: (qmail 11801 invoked by uid 22791); 11 Apr 2007 08:51:06 -0000 X-Spam-Check-By: sourceware.org Received: from server.usilu.net (HELO mail.usilu.net) (195.176.178.200) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 11 Apr 2007 09:51:02 +0100 Received: from [1.240.182.245] ([213.140.22.65] RDNS failed) by mail.usilu.net over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); Wed, 11 Apr 2007 10:51:42 +0200 Message-ID: <461CA157.1020908@lu.unisi.ch> Date: Wed, 11 Apr 2007 08:51:00 -0000 From: Paolo Bonzini Reply-To: bonzini@gnu.org User-Agent: Thunderbird 1.5.0.10 (Macintosh/20070221) MIME-Version: 1.0 To: Andreas Schwab CC: bonzini@gnu.org, Dave Korn , 'Steve Ellcey' , binutils@sourceware.org, gcc-patches@gcc.gnu.org, gdb-patches@gcc.gnu.org, newlib@sourceware.org, Ralf.Wildenhues@gmx.de, aoliva@redhat.com, libtool@cwilson.fastmail.fm Subject: Re: Final(?) patch to update libtool in GCC and src trees References: <006501c77bab$1753a410$2e08a8c0@CAM.ARTIMI.COM> <200704102006.NAA21177@hpsje.cup.hp.com> <008301c77bd6$7fa44bc0$2e08a8c0@CAM.ARTIMI.COM> <461C8FE6.9010800@lu.unisi.ch> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00134.txt.bz2 >> I would rewrite them at the very least as >> >> AC_PROG_AWK >> AC_PROG_CXX >> >> if test "${use_libtool}" = "yes"; then >> AC_LIBTOOL_WIN32_DLL >> AM_PROG_LIBTOOL >> fi > > I think that should use AS_IF instead. Does AS_IF put required macros outside its expansion? That's a cool feature if it does. However, if this is the case, it is also a problem. AM_PROG_LIBTOOL used to expand its subparts via AC_REQUIRE, which would sort of undo the effect of the if statement. Paolo