From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id uf1iI7kftmplLgEAWB0awg (envelope-from ) for ; Fri, 25 Sep 2026 03:16:09 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=OFY6Ismv; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 760D71E06B; Fri, 25 Sep 2026 03:16:09 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5068D1E033 for ; Fri, 25 Sep 2026 03:16:08 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 54BFC4BB58D6 for ; Fri, 25 Sep 2026 07:16:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 54BFC4BB58D6 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=OFY6Ismv Received: from mail-wm2-x11.google.com (mail-wm2-x11.google.com [IPv6:2a00:1450:4864:31::11]) by sourceware.org (Postfix) with ESMTPS id 6729A4BB3BBB for ; Fri, 25 Sep 2026 07:15:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6729A4BB3BBB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6729A4BB3BBB Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:31::11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790320542; cv=none; b=sXX/7mT/IALJa6Y0W/6ewmDvgbWH11lmJnk2dJw+/GXeVWzzc7t/kjKr4Jdpn5RrTp6xFqrEOJUNlnDNQKLOfOdFxbsW4T9cAE4D67GBYu1LOCRj50PnuDiYIWY0+q36b2hX3z+iquoJyhPLH568/6jCacmwcOMzkam7M8es1d0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790320542; c=relaxed/simple; bh=qExarYz1PYK9DBAO19vTWmNT0szP+2bi5f2AMrDF0/k=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=VJrtHtKTdTT4BESZjZSrEQYlUAZ6/aJBBB9gEsRfzdMeWEurel45XbQgS9xKmOEqK6/phLtN9TiTUtDTbdjIokG5CsrAxmOve0XUP9lBIhxTbzzeandjC8ZCMTYMj4Hm4cMrQE9Cvjr1IcbYl+jd1rWZea37XfiByysC3YMCpDU= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=OFY6Ismv DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6729A4BB3BBB Received: by mail-wm2-x11.google.com with SMTP id 5b1f17b1804b1-49e8185e037so2866835e9.3 for ; Fri, 25 Sep 2026 00:15:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790320540; x=1790925340; darn=sourceware.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=1/rb+1EfvEIhMiY28z/LaYciinw6NGonnonoqXmcbLE=; b=OFY6Ismv5O/fAXBpHxAxP6HpXEdX9bebWuRVO/xPc9IPWt0+TZMPyJq8MZtnmS0PNM ZFDaWIJWwMiV2s7P/Rc+T9aYyJcN5pk5gxwRivI+r/RqV7f9j7yAPrIZN0moRr2rXSfy G9TrkM94M3EgtTYUdqCP1GnOFo6Grn4h749R8OtaQN3J4Z7aV7V6x+ceBg1mim89nqut KCC9Ewno5sn0glazhpgUS5jkCbFcYOgCO6h0oUCRDT4kqcdCSOC3AI4ap4odnT8q7p6R a2Zi8bVjhRLuuypO6EwQn62ljgHb2iT90yOtanm5rSFb0ljlIGGZwxHfeNc3rAIBwZ16 w2EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790320540; x=1790925340; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1/rb+1EfvEIhMiY28z/LaYciinw6NGonnonoqXmcbLE=; b=xo0uLuRCHAHP8Mda6GZbVu2X+DnKyuTthNa7MquuWkwQxLa3C3Cbm/o2hf89/RD2PV i5p6QYav+pBeGdblJ8XOaLnDr/8qVRnpK0P42qpk0prVQuW6ohgrD0P2TS3QRkcXzIAa nkDJ1VczwptFrqdXKdHsPZ8f5oltCOOdX4tRNBmLimKwAU3ZaD+6+qb4tYGw6ib7L48W AhhDwfDpm4NPEEUGb24ho/y7o40YQWEgpTQ6iCw5IfYAW9PBoRPnuZNUPW5DcaTsnik4 /0yspEFAeNwQvtn15+/C11RDyr+oUi8PvSqR86ekFBsbWImEjCrhIwN4yyfb/zr/3IbU CUgQ== X-Forwarded-Encrypted: i=1; AKwUvBx2g8SzvU1AVjp0W2TyxaR+8s6xt/d3MjILO7mYdP8lvEApRr5aSCCfnJXLBc4EFB5ix+OwoBvAoQWZAA==@sourceware.org X-Gm-Message-State: AFuF++mvrjwmVRg+ueuFmKMcGAVgj4NUUcEsbdwNGMws/0eBVbzFKpxN KOYLWMiiDHkkMhbm4fwqJBpGgJPGrT7d5j2epSAzNBtXROQi2UST+dk= X-Gm-Gg: AYBFou3o99ZtJQLBbNjzvgruhYy+DECKwQGrTLHSWmrU3d1LBIZVqvSKCvpS7R7Q3a8 eSXk9LUmG5UZHe+OkVW87GVPAzPOcCx7FhazEQ92BjyjRwUOIJ6A3OekYOH5jxyTHm7zgrQg9H/ gCkuDR3HugUQcpe0b+UKQ/PJiiWUyBBA+zWzRgqGRzEIrD/q0jbJAQIE2Q4966lapaiZ1NFDjnm eDiCBLelziUf90m7R+/sVAA97ViVd6X7xsK5VdeHiscJMHSo7mROl86J4hNGdkG0qoCr9o5o2iI VNd3wtq8bSetRCGiIaVwG/qnJTJ5nq2vNlWjEASrdqNRTBbOxBzmdJzuKt+zVU/rhRorFWJ9ByW mrfkIS/sC+lwoc6zdk8SQW/NhtsRzSztfe0U8gyTQc2EG0eULvqUwC1W4iTjFElXtB8SUz0o9Qb Z5vhsklxmohfeSTpDvHqKR0cmxWixuN2xwh5zb2dCKKJR1at0D5AHmvyu1ajQEFI9CCMfsTmIJI vW5z6QsvG5Bm4KCKWtBHjGKAECL7w+PF0Hyna1WUrH3V5UZy5UhdTJGVeqUR9Oil6+T6jiE3/Mh ADp62vewRCwhfAAKaGfWRp79FeJh/0c= X-Received: by 2002:a05:600c:609a:b0:49c:dca2:ac47 with SMTP id 5b1f17b1804b1-49ff06b2db4mr22923725e9.2.1790320540299; Fri, 25 Sep 2026 00:15:40 -0700 (PDT) Received: from ?IPV6:2a01:cb0c:8b36:7600:cfe:3e6a:bf6a:5273? (2a01cb0c8b3676000cfe3e6abf6a5273.ipv6.abo.wanadoo.fr. [2a01:cb0c:8b36:7600:cfe:3e6a:bf6a:5273]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4887a30c43asm4981482f8f.3.2026.09.25.00.15.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Sep 2026 00:15:40 -0700 (PDT) Message-ID: <460be511-ee67-4633-af29-d225219d1c79@gmail.com> Date: Fri, 25 Sep 2026 09:15:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] Fix `add-symbol-file -o ... -s ...` address mapping bug To: Keith Seitz , gdb-patches@sourceware.org References: <20260924035202.4533-1-dragorn421@gmail.com> <20260924035202.4533-2-dragorn421@gmail.com> <4e94fb53-27dd-4f1f-8c46-2b6e5855b269@redhat.com> Content-Language: en-US From: Dragorn421 In-Reply-To: <4e94fb53-27dd-4f1f-8c46-2b6e5855b269@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/24/26 20:54, Keith Seitz wrote: > Hi, > > Thank you for the revision. This looks good, I just note one > tiny nit. > > On 9/23/26 8:51 PM, Dragorn421 wrote: >> diff --git a/gdb/symfile.c b/gdb/symfile.c >> index 017f7a49d8d..5691c2a46d9 100644 >> --- a/gdb/symfile.c >> +++ b/gdb/symfile.c >> @@ -2163,7 +2163,7 @@ set_objfile_default_section_offset (struct >> objfile *objf, >>       } >>           if (cmp == 0) >> -    offsets[objf_sect->sectindex] = 0; >> +    offsets[objf_sect->sectindex] = >> objf->section_offsets[objf_sect->sectindex]; > > This line is now too long. Suggest moving "= ..." to the next line as > per our usual coding convention. No need to repost this patch. Thanks for the review. What do you mean by "No need to repost this patch."? Should I just send the other (test-adding) patch on its own from now on? So will a maintainer possibly take care of formatting that too-long line after applying the patch? > Reviewed-By: Keith Seitz > Keith > >>       } >>       /* Apply the new section offsets.  */ >