From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19012 invoked by alias); 29 Mar 2007 07:45:00 -0000 Received: (qmail 18990 invoked by uid 22791); 29 Mar 2007 07:45:00 -0000 X-Spam-Check-By: sourceware.org Received: from lon-del-01.spheriq.net (HELO lon-del-01.spheriq.net) (195.46.50.97) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 29 Mar 2007 08:44:52 +0100 Received: from lon-out-03.spheriq.net ([195.46.50.131]) by lon-del-01.spheriq.net with ESMTP id l2T7iVqg012059 for ; Thu, 29 Mar 2007 07:44:46 GMT Received: from lon-cus-02.spheriq.net (lon-cus-02.spheriq.net [195.46.50.38]) by lon-out-03.spheriq.net with ESMTP id l2T7iTnm005980 for ; Thu, 29 Mar 2007 07:44:30 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by lon-cus-02.spheriq.net with ESMTP id l2T7iTXY002920 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 29 Mar 2007 07:44:29 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 7F384DA44; Thu, 29 Mar 2007 07:44:28 +0000 (GMT) Received: from mail1.cro.st.com (mail1.cro.st.com [164.129.40.131]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 1F28A47356; Thu, 29 Mar 2007 07:44:28 +0000 (GMT) Received: from [164.129.44.95] (crx595.cro.st.com [164.129.44.95]) by mail1.cro.st.com (MOS 3.7.5a-GA) with ESMTP id CKC61481 (AUTH "denis pilat"); Thu, 29 Mar 2007 09:44:27 +0200 (CEST) Message-ID: <460B6E5A.7000803@st.com> Date: Thu, 29 Mar 2007 07:45:00 -0000 From: Denis PILAT User-Agent: Thunderbird 1.5.0.10 (X11/20070221) MIME-Version: 1.0 To: gdb-patches@sourceware.org, drow@false.org Cc: Nick Roberts , Denis PILAT Subject: Re: [RFC] -thread-select double print stack frame References: <20070328021123.GA28506@caradoc.them.org> <17930.715.767042.438147@farnswood.snap.net.nz> <460A2681.30700@st.com> <45FE948B.9090007@st.com> <17919.12645.81319.568064@kahikatea.snap.net.nz> <4607C863.7080405@st.com> <20070327193257.GM28164@caradoc.them.org> <17929.36634.510715.364996@farnswood.snap.net.nz> <20070328021123.GA28506@caradoc.them.org> <17930.715.767042.438147@farnswood.snap.net.nz> <20070328114256.GA2688@caradoc.them.org> In-Reply-To: <20070328114256.GA2688@caradoc.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-03/txt/msg00306.txt.bz2 >> I do run the testsuite on i386-linux native target, no regression at all. >> Can I commit or not ? >> > > Yes, go ahead. Thanks. > > Just committed ! Attached is the patch: -- Denis 2007-03-29 Denis Pilat * stack.c (print_stack_frame): Always use LOC_AND_ADDRESS in MI output. * infrun.c (normal_stop): Remove MI specific frame printing treatment. Index: stack.c =================================================================== RCS file: /cvs/src/src/gdb/stack.c,v retrieving revision 1.142 diff -u -p -r1.142 stack.c --- stack.c 27 Feb 2007 19:46:04 -0000 1.142 +++ stack.c 26 Mar 2007 13:14:25 -0000 @@ -105,7 +105,8 @@ print_stack_frame (struct frame_info *fr args.frame = frame; args.print_level = print_level; - args.print_what = print_what; + /* For mi, alway print location and address. */ + args.print_what = ui_out_is_mi_like_p (uiout) ? LOC_AND_ADDRESS : print_what; args.print_args = 1; catch_errors (print_stack_frame_stub, &args, "", RETURN_MASK_ALL); Index: infrun.c =================================================================== RCS file: /cvs/src/src/gdb/infrun.c,v retrieving revision 1.223 diff -u -p -r1.223 infrun.c --- infrun.c 9 Mar 2007 16:20:42 -0000 1.223 +++ infrun.c 26 Mar 2007 13:14:39 -0000 @@ -3200,10 +3200,6 @@ Further execution is probably impossible default: internal_error (__FILE__, __LINE__, _("Unknown value.")); } - /* For mi, have the same behavior every time we stop: - print everything but the source line. */ - if (ui_out_is_mi_like_p (uiout)) - source_flag = LOC_AND_ADDRESS; if (ui_out_is_mi_like_p (uiout)) ui_out_field_int (uiout, "thread-id",