From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4SNyHDEaWGMklhAAWB0awg (envelope-from ) for ; Tue, 25 Oct 2022 13:17:37 -0400 Received: by simark.ca (Postfix, from userid 112) id 65FCB1E11A; Tue, 25 Oct 2022 13:17:37 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=tfL4X2cM; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0A6421E0D5 for ; Tue, 25 Oct 2022 13:17:37 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6F6EF385AE4D for ; Tue, 25 Oct 2022 17:17:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6F6EF385AE4D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666718256; bh=VH0wpAfCFl9v6YsOO26zvgfFFEu/lul7LWqvM4cl1/o=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=tfL4X2cM+iQT0RR5KeiMRasW5l/dPPiuvu9UWe6cG/MTkaJFDzg/jiGh9Ii1ENIGR 7A1rdzA1sZ/OgA8JAXj3I50scIqCIC52zZQaKdKmF+K2Lif/wQ9u4+p5a8+oMno1ZT lJYZhu8t2ufS8qRvq3bdnyVq42ULGXjo6tcmFwk0= Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id 4A55C3858415 for ; Tue, 25 Oct 2022 17:17:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4A55C3858415 Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 6E17B300089; Tue, 25 Oct 2022 17:17:12 +0000 (UTC) Message-ID: <45f95875-667a-3f63-db4c-2d135cb9bfe9@irq.a4lg.com> Date: Wed, 26 Oct 2022 02:17:10 +0900 Mime-Version: 1.0 Subject: Re: [PATCH] sim, sim/m32c, sim/rl78: Use getopt_long Content-Language: en-US To: Tom Tromey References: <3b7e769f-b5e9-4049-786f-d00d997f0280@irq.a4lg.com> <24e83e920d728237c4efe6f4720643d6fbbf1084.1666113214.git.research_trasio@irq.a4lg.com> <87sfjhb0r5.fsf@tromey.com> <2024f524-35e3-cdc6-8098-a220daf30c23@irq.a4lg.com> <87y1t3c08e.fsf@tromey.com> In-Reply-To: <87y1t3c08e.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tsukasa OI via Gdb-patches Reply-To: Tsukasa OI Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2022/10/26 1:54, Tom Tromey wrote: >> Glibc (2.25 or before; not too old to drop support) includes >> from but this causes to include Binutils/GCC's >> include/getopt.h. It means, using the filename "getopt.h" in an include >> path (-I) itself is a risk. The only reason it didn't cause a problem >> is most of Binutils/GCC components used getopt_long and >> getopt_long_only, not plain getopt. > > What exactly was the problem? > It seems to me that we'd want to use the libiberty getopt.h, because > we're also linking against the linking getopt. > > Tom > I've described it in the commit message of PATCH v2. If there's other questions, feel free to ask me. Tsukasa