From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27781 invoked by alias); 19 Mar 2007 13:45:24 -0000 Received: (qmail 27759 invoked by uid 22791); 19 Mar 2007 13:45:23 -0000 X-Spam-Check-By: sourceware.org Received: from lon-del-03.spheriq.net (HELO lon-del-03.spheriq.net) (195.46.50.99) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 19 Mar 2007 13:45:16 +0000 Received: from lon-out-02.spheriq.net ([195.46.50.130]) by lon-del-03.spheriq.net with ESMTP id l2JDjDTf023679 for ; Mon, 19 Mar 2007 13:45:13 GMT Received: from lon-cus-01.spheriq.net (lon-cus-01.spheriq.net [195.46.50.37]) by lon-out-02.spheriq.net with ESMTP id l2JDjClX026760 for ; Mon, 19 Mar 2007 13:45:12 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by lon-cus-01.spheriq.net with ESMTP id l2JDjA1C032359 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK); Mon, 19 Mar 2007 13:45:12 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 629EEDA4A; Mon, 19 Mar 2007 13:45:04 +0000 (GMT) Received: from mail1.cro.st.com (mail1.cro.st.com [164.129.40.131]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 21D6147555; Mon, 19 Mar 2007 13:45:04 +0000 (GMT) Received: from [164.129.44.95] (crx595.cro.st.com [164.129.44.95]) by mail1.cro.st.com (MOS 3.7.5a-GA) with ESMTP id CKA05411 (AUTH "denis pilat"); Mon, 19 Mar 2007 14:45:02 +0100 (CET) Message-ID: <45FE93DE.7030704@st.com> Date: Mon, 19 Mar 2007 13:45:00 -0000 From: Denis PILAT User-Agent: Thunderbird 1.5.0.10 (X11/20070221) MIME-Version: 1.0 To: gdb-patches Cc: Nick Roberts Subject: Re: New mi commands for threads References: <45F8200A.3000305@st.com> <17913.46746.760751.573314@kahikatea.snap.net.nz> <45FA57F0.4030107@st.com> <17915.11142.366839.850920@kahikatea.snap.net.nz> In-Reply-To: <17915.11142.366839.850920@kahikatea.snap.net.nz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-03/txt/msg00165.txt.bz2 Nick Roberts wrote: > > This output is a side effect of the frame printing, the actual > > -thread-select command has the same. I'm going to have a look at how we > > can avoid it, but I think it will impact *-thread-select* as well. > > OK, I dodn't realise that. Interestingly the example in the manual doesn't > show the duplicate information (or the fullname field, so it will have to be > updated). It seems to due to the fact that do_captured_thread_select uses > SRC_AND_LOC, while the other MI commands use LOC_AND_ADDRESS. I see that > normal_stop specifies LOC_AND_ADDRESS specifically for MI. It looks a bit > of a hack but perhaps we should do the same for do_captured_thread_select: > > /* For mi, have the same behavior every time we stop: > print everything but the source line. */ > if (ui_out_is_mi_like_p (uiout)) > source_flag = LOC_AND_ADDRESS; > > > Right, I'm going to propose a separate patch for that right now. Then I'll do the same for -thread-info new command. Denis