From: Brian Dessent <brian@dessent.net>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sourceware.org, insight@sourceware.org
Subject: Re: [rfc] Remove deprecated_selected_frame
Date: Sun, 04 Mar 2007 03:13:00 -0000 [thread overview]
Message-ID: <45EA394A.1C292B19@dessent.net> (raw)
In-Reply-To: <20070222212909.GA17260@caradoc.them.org>
Daniel Jacobowitz wrote:
> Every reference to the global selected frame is either replaced by
> get_selected_frame (if we know the program is running) or
> deprecated_safe_get_selected_frame (if we're not sure). This removes
> a class of bugs caused by lazy creation of the selected frame, several
> of which Debian users have reported to me. It also simplifies some
> other frame cleanups.
I'm getting this now when building insight:
gcc -c -g -O2 -I. -I/usr/src/sourceware/gdb
-I/usr/src/sourceware/gdb/config
-DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H
-I/usr/src/sourceware/gdb/../include/opcode
-I/usr/src/sourceware/gdb/../readline/.. -I../bfd
-I/usr/src/sourceware/gdb/../bfd -I/usr/src/sourceware/gdb/../include
-DMI_OUT=1 -DGDBTK -DTUI=1 -Wall -Wdeclaration-after-statement
-Wpointer-arith -Wformat-nonliteral -Wno-unused -Wno-switch -Werror
-I/usr/src/sourceware/gdb/../libgui/src
-I/usr/src/sourceware/itcl/itcl/generic \
-I/usr/src/sourceware/tcl/generic
-I/usr/src/sourceware/tk/generic
-I"/usr/src/sourceware/tk/xlib" \
/usr/src/sourceware/gdb/gdbtk/generic/gdbtk-cmds.c
\
-DGDBTK_LIBRARY=\"/usr/local/share/insight1.0\"
/usr/src/sourceware/gdb/gdbtk/generic/gdbtk-cmds.c: In function
`gdb_loc':
/usr/src/sourceware/gdb/gdbtk/generic/gdbtk-cmds.c:2133: error:
`deprecated_selected_frame' undeclared (first use in this function)
/usr/src/sourceware/gdb/gdbtk/generic/gdbtk-cmds.c:2133: error: (Each
undeclared identifier is reported only once
/usr/src/sourceware/gdb/gdbtk/generic/gdbtk-cmds.c:2133: error: for each
function it appears in.)
make: *** [gdbtk-cmds.o] Error 1
It looks like there are about a dozen more references in
gdbtk/generic/gdbtk-{cmds,hooks,register,stack}.c. Most of them seem to
be the "if (deprecated_selected_frame != NULL)" sort of thing -- is this
safe to just replace with "if (get_selected_frame (NULL))" ?
Brian
next prev parent reply other threads:[~2007-03-04 3:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-22 21:29 Daniel Jacobowitz
2007-02-27 19:45 ` Daniel Jacobowitz
2007-03-04 3:13 ` Brian Dessent [this message]
2007-03-05 12:45 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45EA394A.1C292B19@dessent.net \
--to=brian@dessent.net \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=insight@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox