From: Markus Deuling <deuling@de.ibm.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: Daniel Jacobowitz <drow@false.org>,
GDB Patches <gdb-patches@sourceware.org>
Subject: Re: Patch: Add arch_string to spu-low.c
Date: Thu, 22 Feb 2007 16:36:00 -0000 [thread overview]
Message-ID: <45DDC655.8040903@de.ibm.com> (raw)
In-Reply-To: <200702221534.l1MFY8Rh001300@d12av02.megacenter.de.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 385 bytes --]
Hi,
> Ah, thanks for the explanation. I agree that "spu" would be the
> better choice then.
"spu" works. I attached a new correct patch. If ok, then please take this one for commit.
ChangeLog:
* spu-low.c (spu_arch_string): New.
(spu_target_ops): Add spu_arch_string.
Regards,
Markus
--
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com
[-- Attachment #2: diff-spu-arch-string --]
[-- Type: text/plain, Size: 584 bytes --]
diff -urN src.orig/gdb/gdbserver/spu-low.c src/gdb/gdbserver/spu-low.c
--- src.orig/gdb/gdbserver/spu-low.c 2007-01-09 18:59:08.000000000 +0100
+++ src/gdb/gdbserver/spu-low.c 2007-02-22 16:49:11.000000000 +0100
@@ -556,6 +556,12 @@
syscall (SYS_tkill, current_tid, signo);
}
+static const char *
+spu_arch_string (void)
+{
+ return "spu";
+}
+
\f
static struct target_ops spu_target_ops = {
spu_create_inferior,
@@ -572,6 +578,13 @@
spu_look_up_symbols,
spu_send_signal,
NULL,
+ NULL,
+ NULL,
+ NULL,
+ NULL,
+ NULL,
+ NULL,
+ spu_arch_string,
};
void
next prev parent reply other threads:[~2007-02-22 16:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-22 14:33 Markus Deuling
2007-02-22 14:56 ` Daniel Jacobowitz
2007-02-22 15:21 ` Ulrich Weigand
2007-02-22 15:30 ` Daniel Jacobowitz
2007-02-22 15:34 ` Ulrich Weigand
2007-02-22 16:36 ` Markus Deuling [this message]
2007-02-22 16:45 ` Daniel Jacobowitz
2007-02-22 17:42 ` Ulrich Weigand
2007-02-22 14:57 Markus Deuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45DDC655.8040903@de.ibm.com \
--to=deuling@de.ibm.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox