Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Denis PILAT <denis.pilat@st.com>
To: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFA] [gdb.threads/testsuite] failure while checking backtrace into main
Date: Fri, 02 Feb 2007 14:28:00 -0000	[thread overview]
Message-ID: <45C34A05.1060901@st.com> (raw)
In-Reply-To: <45C0C028.1050401@st.com>

[-- Attachment #1: Type: text/plain, Size: 549 bytes --]


> While checking for non-regression in the gdb.threads part of the 
> testsuite, I noticed one test fails with gcc4 since the argument of 
> the main are removed by the compiler so don't appear when printing 
> backtrace:
> FAIL: gdb.threads/pthreads.exp: check backtrace from main thread
>
> Either we can change the .exp file to avoid checking these arguments, 
> or we can ensure compiler keeps them as proposed hereby.

We can also just remove the testing of argc and argv from the 
pthreads.exp file, that would be better I think.

-- 
Denis


[-- Attachment #2: pthreads.exp.patch --]
[-- Type: text/plain, Size: 743 bytes --]

2007-02-02  Denis Pilat  <denis.pilat@st.com>

	* gdb.threads/pthreads.exp: remove checking of unused argc and argv
	since they can be removed by a compiler optiisation.

Index: testsuite/gdb.threads/pthreads.exp
===================================================================
--- testsuite/gdb.threads/pthreads.exp	(revision 553)
+++ testsuite/gdb.threads/pthreads.exp	(working copy)
@@ -261,7 +261,7 @@
     # Check that the "thread apply N backtrace" command works
 
     gdb_test "thread apply $main_id backtrace" \
-	    ".* in main \\(argc=.*, argv=.*\\).*" \
+	    ".* in main \\(.*\\).*" \
 	    "check backtrace from main thread"
     gdb_test "thread apply $thread1_id backtrace" \
 	    ".* in thread1 \\(arg=0xfeedface\\).*" \

  reply	other threads:[~2007-02-02 14:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-31 19:36 Denis PILAT
2007-02-02 14:28 ` Denis PILAT [this message]
2007-02-02 14:36   ` Daniel Jacobowitz
2007-02-02 15:18     ` Denis PILAT
2007-02-03  1:35       ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45C34A05.1060901@st.com \
    --to=denis.pilat@st.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox