From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26892 invoked by alias); 1 Feb 2007 09:49:40 -0000 Received: (qmail 26875 invoked by uid 22791); 1 Feb 2007 09:49:39 -0000 X-Spam-Check-By: sourceware.org Received: from vir-del-03.spheriq.net (HELO vir-del-03.spheriq.net) (194.50.41.42) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 01 Feb 2007 09:49:28 +0000 Received: from vir-out-01.spheriq.net ([194.50.41.30]) by vir-del-03.spheriq.net with ESMTP id l119Ecbv009294 for ; Thu, 1 Feb 2007 09:14:38 GMT Received: from vir-cus-02.spheriq.net (vir-cus-02.spheriq.net [194.50.41.86]) by vir-out-01.spheriq.net with ESMTP id l119EbKx011919 for ; Thu, 1 Feb 2007 09:14:37 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by vir-cus-02.spheriq.net with ESMTP id l119ESOb016701 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 1 Feb 2007 09:14:36 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id CFD08DA4B for ; Thu, 1 Feb 2007 09:14:25 +0000 (GMT) Received: from mail1.cro.st.com (mail1.cro.st.com [164.129.40.131]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 5D2CD473E6 for ; Thu, 1 Feb 2007 09:14:25 +0000 (GMT) Received: from [164.129.44.95] (crx595.cro.st.com [164.129.44.95]) by mail1.cro.st.com (MOS 3.7.5a-GA) with ESMTP id CJP85725 (AUTH "denis pilat"); Thu, 1 Feb 2007 10:14:23 +0100 (CET) Message-ID: <45C1AF6E.9080900@st.com> Date: Thu, 01 Feb 2007 09:49:00 -0000 From: Denis PILAT User-Agent: Thunderbird 1.5.0.9 (X11/20061206) MIME-Version: 1.0 To: Denis PILAT , gdb-patches Subject: Re: [RFA] thread apply commands change selected frame References: <45A61E73.8030400@st.com> <20070121173341.GG12463@nevyn.them.org> <45B73813.9060005@st.com> <45C05A1A.6010109@st.com> <20070131145407.GA24233@nevyn.them.org> <45C0BC7E.80409@st.com> <20070131193254.GA7389@nevyn.them.org> In-Reply-To: <20070131193254.GA7389@nevyn.them.org> Content-Type: multipart/mixed; boundary="------------060107080200020907030707" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00004.txt.bz2 This is a multi-part message in MIME format. --------------060107080200020907030707 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 694 Daniel Jacobowitz wrote: > On Wed, Jan 31, 2007 at 04:57:50PM +0100, Denis PILAT wrote: > >> Your remarks have been taken into account into the attached patch. >> Are you ok for committing this one plus the previous patch regarding the >> thread.c ? >> (Frederic Riss will do that for me) >> > > Yes, that's OK (with a minor fix, below). Let me know if you would > like write access yourself. > Yes thanks. > Checking for $[specific number] should be avoided, because adding more > tests earlier in the file will break it. Use \\\$\[0-9]+ instead. > > I prefer that as well, therefore I changed the previous test as well to keep the same style (see attached file). -- Denis --------------060107080200020907030707 Content-Type: text/plain; name="threadapply.exp.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="threadapply.exp.patch" Content-length: 1525 2007-02-01 Denis Pilat * gdb.threads/threadapply.exp: check that frame is not changed by the thread apply all command. Index: testsuite/gdb.threads/threadapply.exp =================================================================== --- testsuite/gdb.threads/threadapply.exp (revision 553) +++ testsuite/gdb.threads/threadapply.exp (working copy) @@ -67,5 +67,11 @@ gdb_test_multiple "define backthread" "d # verify that the macro can get past the backtrace error and perform # subsequent commands. gdb_test "set backtrace limit 3" "" -gdb_test "thread apply all backthread" "Thread ..*\\\$1 = 0x14.*Thread ..*\\\$2 = 0x14.*Thread ..*\\\$3 = 0x14.*Thread ..*\\\$4 = 0x14.*Thread ..*\\\$5 = 0x14.*Thread ..*\\\$. = 0x14" +gdb_test "thread apply all backthread" "Thread ..*\\\$\[0-9]+ = 0x14.*Thread ..*\\\$\[0-9]+ = 0x14.*Thread ..*\\\$\[0-9]+ = 0x14.*Thread ..*\\\$\[0-9]+ = 0x14.*Thread ..*\\\$\[0-9]+ = 0x14.*Thread ..*\\\$\[0-9]+ = 0x14" +# Go into the thread_function to check that a simple "thread apply" +# does not change the selected frame. +gdb_test "step" "thread_function.*" "step to the thread_function" +gdb_test "up" ".*in main.*" "go up in the stack frame" +gdb_test "thread apply all print 1" "Thread ..*\\\$\[0-9]+ = 1.*Thread ..*\\\$\[0-9]+ = 1.*Thread ..*\\\$\[0-9]+ = 1.*Thread ..*\\\$\[0-9]+ = 1.*Thread ..*\\\$\[0-9]+ = 1.*Thread ..*\\\$\[0-9]+ = 1" "run a simple print command on all threads" +gdb_test "down" "#0.*thread_function.*" "go down and check selected frame" --------------060107080200020907030707--