Daniel Jacobowitz wrote: > On Wed, Jan 31, 2007 at 04:57:50PM +0100, Denis PILAT wrote: > >> Your remarks have been taken into account into the attached patch. >> Are you ok for committing this one plus the previous patch regarding the >> thread.c ? >> (Frederic Riss will do that for me) >> > > Yes, that's OK (with a minor fix, below). Let me know if you would > like write access yourself. > Yes thanks. > Checking for $[specific number] should be avoided, because adding more > tests earlier in the file will break it. Use \\\$\[0-9]+ instead. > > I prefer that as well, therefore I changed the previous test as well to keep the same style (see attached file). -- Denis