From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30388 invoked by alias); 31 Jan 2007 19:30:40 -0000 Received: (qmail 30379 invoked by uid 22791); 31 Jan 2007 19:30:38 -0000 X-Spam-Check-By: sourceware.org Received: from lon-del-02.spheriq.net (HELO lon-del-02.spheriq.net) (195.46.50.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 31 Jan 2007 19:30:26 +0000 Received: from lon-out-03.spheriq.net ([195.46.50.131]) by lon-del-02.spheriq.net with ESMTP id l0VJUMVb004197 for ; Wed, 31 Jan 2007 19:30:22 GMT Received: from lon-cus-01.spheriq.net (lon-cus-01.spheriq.net [195.46.50.37]) by lon-out-03.spheriq.net with ESMTP id l0VJULcW025016 for ; Wed, 31 Jan 2007 19:30:21 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by lon-cus-01.spheriq.net with ESMTP id l0VJUIQF005850 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK); Wed, 31 Jan 2007 19:30:21 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id C8B83F069; Wed, 31 Jan 2007 15:58:00 +0000 (GMT) Received: from mail1.cro.st.com (mail1.cro.st.com [164.129.40.131]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 5B3D74745D; Wed, 31 Jan 2007 15:58:00 +0000 (GMT) Received: from [164.129.44.95] (crx595.cro.st.com [164.129.44.95]) by mail1.cro.st.com (MOS 3.7.5a-GA) with ESMTP id CJP71704 (AUTH "denis pilat"); Wed, 31 Jan 2007 16:57:51 +0100 (CET) Message-ID: <45C0BC7E.80409@st.com> Date: Wed, 31 Jan 2007 19:30:00 -0000 From: Denis PILAT User-Agent: Thunderbird 1.5.0.9 (X11/20061206) MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches Subject: Re: [RFC] thread apply commands change selected frame References: <45A61E73.8030400@st.com> <20070121173341.GG12463@nevyn.them.org> <45B73813.9060005@st.com> <45C05A1A.6010109@st.com> <20070131145407.GA24233@nevyn.them.org> In-Reply-To: <20070131145407.GA24233@nevyn.them.org> Content-Type: multipart/mixed; boundary="------------020705000505090603030202" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00623.txt.bz2 This is a multi-part message in MIME format. --------------020705000505090603030202 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 513 > The default name for a test is the command, if you don't specify a > name. These are pretty generic commands, but test names are supposed > to be unique within a .exp file. I would recommend giving them names > (and probably checking their output, at least a little, too...). > > Your remarks have been taken into account into the attached patch. Are you ok for committing this one plus the previous patch regarding the thread.c ? (Frederic Riss will do that for me) -- Denis Pilat STMicroelectronics --------------020705000505090603030202 Content-Type: text/plain; name="threadapply.exp.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="threadapply.exp.patch" Content-length: 1176 2007-01-31 Denis Pilat * gdb.threads/threadapply.exp: check that frame is not changed by the thread apply all command. Index: testsuite/gdb.threads/threadapply.exp =================================================================== --- testsuite/gdb.threads/threadapply.exp (revision 553) +++ testsuite/gdb.threads/threadapply.exp (working copy) @@ -69,3 +69,9 @@ gdb_test_multiple "define backthread" "d gdb_test "set backtrace limit 3" "" gdb_test "thread apply all backthread" "Thread ..*\\\$1 = 0x14.*Thread ..*\\\$2 = 0x14.*Thread ..*\\\$3 = 0x14.*Thread ..*\\\$4 = 0x14.*Thread ..*\\\$5 = 0x14.*Thread ..*\\\$. = 0x14" +# Go into the thread_function to check that a simple "thread apply" +# does not change the selected frame. +gdb_test "step" "thread_function.*" "step to the thread_function" +gdb_test "up" ".*in main.*" "go up in the stack frame" +gdb_test "thread apply all print 1" "Thread ..*\\\$7 = 1.*Thread ..*\\\$8 = 1.*Thread ..*\\\$9 = 1.*Thread ..*\\\$10 = 1.*Thread ..*\\\$11 = 1.*Thread ..*\\\$12 = 1" "run a simple print command on all thread" +gdb_test "down" "#0.*thread_function.*" "go down and check selected frame" --------------020705000505090603030202--