Daniel Jacobowitz wrote: > I haven't looked at the patch yet, just Nick's comments, which I > generally agree with :-) > > On Fri, Jan 26, 2007 at 11:31:35AM +1300, Nick Roberts wrote: > >> Is xstrdup just a simpler version of savestring? i.e. >> >> tmp_var->obj_name = xstrdup (*varp)->obj_name); >> > > Yes - savestring is handy for saving only part of a string but xstrdup > is clearer. > > Attached is a new implementation, it takes care of more cases where seg fault occured. I take Nick's suggestion into account, -var-update outputs the following for invalid variables: changelist=[{name="linteger",in_scope="invalid"}] About this last change, I'm wondering if frond-ends that expect "true" or "false" will handle this new outputs correctly, it's just a question of backward compatibility. Of course it will be better that the old behavior that crashes gdb ! If you're fine I'll write appropriate ChangeLogs. I also wrote a new .exp file in gdb.mi testsuite, I'll propose it on this one approval. -- Denis