From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10747 invoked by alias); 18 Jan 2007 12:37:40 -0000 Received: (qmail 10734 invoked by uid 22791); 18 Jan 2007 12:37:38 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.29.154) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 18 Jan 2007 12:37:28 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id l0ICbPC5167082 for ; Thu, 18 Jan 2007 12:37:25 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.2) with ESMTP id l0ICbOKB2490382 for ; Thu, 18 Jan 2007 13:37:24 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l0ICbOSD031281 for ; Thu, 18 Jan 2007 13:37:24 +0100 Received: from [9.152.248.39] (dyn-9-152-248-39.boeblingen.de.ibm.com [9.152.248.39]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l0ICbOOC031276 for ; Thu, 18 Jan 2007 13:37:24 +0100 Message-ID: <45AF6A01.1020605@de.ibm.com> Date: Thu, 18 Jan 2007 12:37:00 -0000 From: Markus Deuling User-Agent: Thunderbird 1.5.0.9 (X11/20070102) MIME-Version: 1.0 To: GDB Patches Subject: [RFA] gdb/gdbserver/linux-ppc-low.c: Wrong return value in ppc_cannot_store_register() Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00401.txt.bz2 Hi, ppc_cannot_store_register() from linux-ppc-low.c returns 2 instead of 1. This seems to be broken. In linux-low.c:usr_store_inferior_registers() there is following comparison: if ((*the_low_target.cannot_store_register) (regno) == 1) return; This won't work with ppc low target. The patch returns 1 instead of 2. Is it ok to apply ? ChangeLog: * linux-ppc-low.c (ppc_cannot_store_register): Return 1 instead of 2. ==================================================== diff -urN src/gdb/gdbserver/linux-ppc-low.c dev/gdb/gdbserver/linux-ppc-low.c --- src/gdb/gdbserver/linux-ppc-low.c 2007-01-10 15:48:11.000000000 +0100 +++ dev/gdb/gdbserver/linux-ppc-low.c 2007-01-18 13:27:50.000000000 +0100 @@ -53,7 +53,7 @@ { /* Some kernels do not allow us to store fpscr. */ if (regno == find_regno ("fpscr")) - return 2; + return 1; return 0; } Regards, Markus -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com