From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6004 invoked by alias); 18 Jan 2007 09:15:26 -0000 Received: (qmail 5971 invoked by uid 22791); 18 Jan 2007 09:15:23 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate2.de.ibm.com (HELO mtagate2.de.ibm.com) (195.212.29.151) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 18 Jan 2007 09:15:16 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate2.de.ibm.com (8.13.8/8.13.8) with ESMTP id l0I9FBqZ149080 for ; Thu, 18 Jan 2007 09:15:11 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.2) with ESMTP id l0I9FAXc2523220 for ; Thu, 18 Jan 2007 10:15:10 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l0I9F8es032701 for ; Thu, 18 Jan 2007 10:15:08 +0100 Received: from [9.152.248.39] (dyn-9-152-248-39.boeblingen.de.ibm.com [9.152.248.39]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l0I9F8oi032660; Thu, 18 Jan 2007 10:15:08 +0100 Message-ID: <45AF3A99.3020105@de.ibm.com> Date: Thu, 18 Jan 2007 09:15:00 -0000 From: Markus Deuling User-Agent: Thunderbird 1.5.0.9 (X11/20070102) MIME-Version: 1.0 To: Mark Kettenis CC: gdb-patches@sourceware.org, drow@false.org Subject: Re: [RFA]: gdb/testsuite/gdb.arch/altivec-regs.exp Broken testcase References: <45AC7532.6010108@de.ibm.com> <200701162128.l0GLS1U4024821@brahms.sibelius.xs4all.nl> <20070117055939.GA19331@nevyn.them.org> <45ADC40B.6000500@de.ibm.com> <200701172148.l0HLmPGJ021678@brahms.sibelius.xs4all.nl> In-Reply-To: <200701172148.l0HLmPGJ021678@brahms.sibelius.xs4all.nl> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00400.txt.bz2 Hi, Mark Kettenis schrieb: >> Date: Wed, 17 Jan 2007 07:36:59 +0100 >> From: Markus Deuling >> >> But I think inserting >> +set endianness "" >> is a good idea. Then the testcase would have FAILed instead of abort >> with an error. > > I agree. Feel free to commit that bit. > > Mark > this is the patch without the new branch. Could you please commit it? Thank you very much. ChangeLog: *gdb.arch/altivec-regs.exp: Initialise variable endianness in every case. ============================================================= --- src/gdb/testsuite/gdb.arch/altivec-regs.exp 2007-01-17 06:57:45.000000000 +0100 +++ dev/gdb/testsuite/gdb.arch/altivec-regs.exp 2007-01-18 10:12:24.000000000 +0100 @@ -89,6 +89,7 @@ gdb_test "next" "" "" send_gdb "show endian\n" +set endianness "" gdb_expect { -re "(The target endianness is set automatically .currently )(big|little)( endian.*)$gdb_prompt $" { pass "endianness" Regards, Markus -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com