Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Denis PILAT <denis.pilat@st.com>
To: Denis PILAT <denis.pilat@st.com>,
	gdb-patches <gdb-patches@sourceware.org>
Subject: Re: gdbserver with reversed arguments goes into an infinite loop
Date: Wed, 03 Jan 2007 09:08:00 -0000	[thread overview]
Message-ID: <459B7296.6000808@st.com> (raw)
In-Reply-To: <20061230154533.GC15107@nevyn.them.org>

Daniel Jacobowitz wrote:
> On Wed, Dec 13, 2006 at 04:45:53PM +0100, Denis PILAT wrote:
>   
>> But may be it would be better to open only character device (S_ISCHR 
>> macro) than excluding ordinary files (S_ISREG macro). It's up to you !
>>     
>
> Good idea.  FIFOs are OK too.  I've committed a nicer version of this.
>
>   
>> I took this opportunity to remove a warning on a strncpy() usage.
>>     
>
> Why did it warn?  I omitted this bit, because I don't see any reason
> (or any warning).
>
>   
>> I'm wondering about the compilation of this code under windows. I never 
>> compiled a gdbserver on windows, is there any gdbserver hosted under 
>> windows ?
>>     
>
> If you were working against HEAD, you'd see that there was now - but
> we don't support serial ports there, so it's not a problem.  It's all
> #ifdef'd out.
>
>   
Daniel,
Thanks for your commit, I was working on a 6.5 version, so far from the 
HEAD.
About the warning, gcc4.1.1 emit the following:
    remote-utils.c:653: warning: value computed is not used
I think it is because the returned value of strncpy is not used but it 
seems to be a gcc4.1 problem. Moreover it occures only in -01 or -02.

About your patch, the infinite loop has gone but I'm having a 
segmentation fault when argument are reversed.
I'm about to propose a patch in a new mail to avoid confusion.

Denis



      reply	other threads:[~2007-01-03  9:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-13  9:58 Denis PILAT
2006-12-13 13:37 ` Daniel Jacobowitz
2006-12-13 15:46   ` Denis PILAT
2006-12-30 15:45     ` Daniel Jacobowitz
2007-01-03  9:08       ` Denis PILAT [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=459B7296.6000808@st.com \
    --to=denis.pilat@st.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox