From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26787 invoked by alias); 10 Dec 2006 16:54:39 -0000 Received: (qmail 26631 invoked from network); 10 Dec 2006 16:54:23 -0000 Received: from unknown (195.23.133.212) by sourceware.org with QMTP; 10 Dec 2006 16:54:23 -0000 Received: (qmail 17433 invoked from network); 10 Dec 2006 16:54:22 -0000 Received: from unknown (HELO mailfrt09.isp.novis.pt) ([195.23.133.201]) (envelope-sender ) by mailrly02.isp.novis.pt with compressed SMTP; 10 Dec 2006 16:54:22 -0000 Received: (qmail 12411 invoked from network); 10 Dec 2006 16:54:21 -0000 Received: from unknown (HELO [127.0.0.1]) ([195.23.225.203]) (envelope-sender ) by mailfrt09.isp.novis.pt with SMTP; 10 Dec 2006 16:54:21 -0000 Message-ID: <457C3BA2.3010801@portugalmail.pt> Date: Sun, 10 Dec 2006 16:54:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; pt-BR; rv:1.8.0.8) Gecko/20061025 Thunderbird/1.5.0.8 Mnenhy/0.7.4.0 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [RFH] Cygwin (EXEEXT) fix. References: <457C1BBA.8020802@portugalmail.pt> <20061210155602.GA22340@nevyn.them.org> In-Reply-To: <20061210155602.GA22340@nevyn.them.org> Content-Type: multipart/mixed; boundary="------------070900030202090403010300" X-Antivirus: avast! (VPS 0655-1, 08-12-2006), Outbound message X-Antivirus-Status: Clean X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00152.txt.bz2 This is a multi-part message in MIME format. --------------070900030202090403010300 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1120 Daniel Jacobowitz escreveu: > On Sun, Dec 10, 2006 at 02:37:46PM +0000, Pedro Alves wrote: >> gdb_expect_list "run until main breakpoint" "$gdb_prompt$" { >> "\r\n\032\032post-prompt\r\n" > > This is a TCL list. { } are quotes, like ' ' in the shell, which > prevent expansion. > > Try changing it to [list "..." "..."], but you'll need to check the > quoting in every element and add backslashes at the end of every line. Ah, I see. But shouldn't a command work too? If not, then I don't understand is how this in gdb.arch/altivec-regs.exp can work. gdb_expect_list "info vector" ".*$gdb_prompt $" { [$pattern0] [$pattern1] [$pattern2] [$pattern3] (...) } > Or, you can just add (|\.exe) instead of $EXEEXT... much simpler. > > That is what I have in my local tree, but I though that it wouldn't be acceptable, since it feels like a hack. :) Since it is, then please find the patch attached. Please review and commit. Cheers, Pedro Alves --- gdb/testsuite/ChangeLog: 2006-12-10 Pedro Alves * gdb.base/annota3.exp ($binfile): Append $EXEEXT. Expect ".exe" extension. --------------070900030202090403010300 Content-Type: text/plain; name="annota3.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="annota3.diff" Content-length: 977 Index: gdb.base/annota3.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/annota3.exp,v retrieving revision 1.9 diff -u -p -r1.9 annota3.exp --- gdb.base/annota3.exp 10 Aug 2006 05:27:20 -0000 1.9 +++ gdb.base/annota3.exp 10 Dec 2006 16:47:50 -0000 @@ -39,7 +39,7 @@ set bug_id 0 set testfile "annota3" set srcfile ${testfile}.c -set binfile ${objdir}/${subdir}/${testfile} +set binfile ${objdir}/${subdir}/${testfile}$EXEEXT if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug nowarnings}] != "" } { untested annota3.exp @@ -118,7 +118,7 @@ gdb_expect_list "breakpoint info" "$gdb_ send_gdb "run\n" gdb_expect_list "run until main breakpoint" "$gdb_prompt$" { "\r\n\032\032post-prompt\r\n" - "Starting program: .*annota3 \r\n" + "Starting program: .*annota3(|\.exe) \r\n" "\r\n\032\032starting\r\n" "\r\n\032\032breakpoint 1\r\n" "\r\n" --------------070900030202090403010300--