From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15188 invoked by alias); 7 Dec 2006 17:03:47 -0000 Received: (qmail 15178 invoked by uid 22791); 7 Dec 2006 17:03:46 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 07 Dec 2006 17:03:40 +0000 Received: (qmail 22528 invoked from network); 7 Dec 2006 17:03:38 -0000 Received: from unknown (HELO ?192.168.189.103?) (nathan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 7 Dec 2006 17:03:38 -0000 Message-ID: <45784983.4040504@codesourcery.com> Date: Thu, 07 Dec 2006 17:03:00 -0000 From: Nathan Sidwell User-Agent: Thunderbird 1.5.0.8 (X11/20061115) MIME-Version: 1.0 To: gdb-patches@sourceware.org, Nathan Sidwell Subject: Re: [rfc] Simplified XML parsing References: <20061207160228.GA16211@nevyn.them.org> In-Reply-To: <20061207160228.GA16211@nevyn.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00101.txt.bz2 Daniel Jacobowitz wrote: > This patch rewrites the memory-map parser, dividing it into an > infrastructure and a set of tables and action functions. The bulk of the > parser now looks like this: Great! > Any thoughts on this patch? Nathan, could you take a quick look at the > header and see if I stripped out something I ought to have left in? I couldn't see anything wrong. One thing this patch should allow you to do is remove the '#include 's from all but the xml processing file itself. nathan -- Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery nathan@codesourcery.com :: http://www.planetfall.pwp.blueyonder.co.uk