From: Nathan Sidwell <nathan@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Daniel Jacobowitz <dan@codesourcery.com>
Subject: adjust linux-dp test
Date: Wed, 29 Nov 2006 14:58:00 -0000 [thread overview]
Message-ID: <456DA000.6030908@codesourcery.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 505 bytes --]
My recent change to linux-dp.exp wasn't robust because (a) some thread ids can
be negative numbers and (b) sometimes you'd get a 'cannot access memory' error
in printing out a prototype, and that would mess up the \n placement.
This patch fixes those two problems, and renames the tests to be unique.
tested on i686-pc-linux-gnu, ok?
nathan
--
Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery
nathan@codesourcery.com :: http://www.planetfall.pwp.blueyonder.co.uk
[-- Attachment #2: linux.patch --]
[-- Type: text/x-patch, Size: 3206 bytes --]
2006-11-29 Nathan Sidwell <nathan@codesourcery.com>
* gdb.threads/linux-dp.exp: Adjust regexps used to scan thread
info. Adjust test names.
Index: testsuite/gdb.threads/linux-dp.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/linux-dp.exp,v
retrieving revision 1.12
diff -c -3 -p -r1.12 linux-dp.exp
*** testsuite/gdb.threads/linux-dp.exp 28 Nov 2006 15:16:48 -0000 1.12
--- testsuite/gdb.threads/linux-dp.exp 29 Nov 2006 14:51:12 -0000
*************** for {set i 0} {$i < 5} {incr i} {
*** 73,79 ****
-re "info threads\r\n" {
exp_continue
}
! -re "^\\*? +(\[0-9\]+ Thread \[0-9\]+) \[^\n\]*\n" {
verbose -log "found thread $expect_out(1,string)" 2
lappend threads_before $expect_out(1,string)
exp_continue
--- 73,79 ----
-re "info threads\r\n" {
exp_continue
}
! -re "^. +(\[0-9\]+ Thread \[-0-9\]+) (\[^\n\]|Cannot access memory \[^\n\]*\n)*\n" {
verbose -log "found thread $expect_out(1,string)" 2
lappend threads_before $expect_out(1,string)
exp_continue
*************** for {set i 0} {$i < 5} {incr i} {
*** 81,87 ****
-re "^$gdb_prompt $" {
}
timeout {
! fail "(timeout) info threads"
}
}
send_gdb "next\n"
--- 81,87 ----
-re "^$gdb_prompt $" {
}
timeout {
! fail "(timeout) info threads before: $i"
}
}
send_gdb "next\n"
*************** for {set i 0} {$i < 5} {incr i} {
*** 139,145 ****
-re "info threads\r\n" {
exp_continue
}
! -re "^\\*? +(\[0-9\]+ Thread \[0-9\]+) \[^\n\]+\n" {
set name $expect_out(1,string)
for {set j 0} {$j != [llength $threads_before] } {incr j} {
if {$name == [lindex $threads_before $j]} {
--- 139,145 ----
-re "info threads\r\n" {
exp_continue
}
! -re "^. +(\[0-9\]+ Thread \[-0-9\]+) (\[^\n\]|Cannot access memory \[^\n\]*\n)*\n" {
set name $expect_out(1,string)
for {set j 0} {$j != [llength $threads_before] } {incr j} {
if {$name == [lindex $threads_before $j]} {
*************** for {set i 0} {$i < 5} {incr i} {
*** 155,175 ****
}
-re "^$gdb_prompt $" {
if { [llength $threads_before] != 0 } {
! fail "create philosopher: $i"
} elseif { !$i && [llength $threads_after] == 2 } {
set expect_manager 1
! pass "create philosopher: $i"
} elseif { [llength $threads_after] == 1 } {
if { $expect_manager < 0 } {
set expect_manager 0
}
! pass "create philosopher: $i"
} else {
! fail "create philosopher: $i"
}
}
timeout {
! fail "(timeout) info threads"
}
}
--- 155,175 ----
}
-re "^$gdb_prompt $" {
if { [llength $threads_before] != 0 } {
! fail "info threads after: $i"
} elseif { !$i && [llength $threads_after] == 2 } {
set expect_manager 1
! pass "info threads after: $i"
} elseif { [llength $threads_after] == 1 } {
if { $expect_manager < 0 } {
set expect_manager 0
}
! pass "info threads after: $i"
} else {
! fail "info threads after: $i"
}
}
timeout {
! fail "(timeout) info threads after: $i"
}
}
next reply other threads:[~2006-11-29 14:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-29 14:58 Nathan Sidwell [this message]
2006-11-29 15:08 ` Daniel Jacobowitz
2006-11-29 15:15 ` Nathan Sidwell
2006-11-29 15:24 ` Daniel Jacobowitz
2006-11-29 15:30 ` Nathan Sidwell
2006-11-29 15:33 ` Daniel Jacobowitz
2006-11-29 15:59 ` Nathan Sidwell
2006-11-29 16:03 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=456DA000.6030908@codesourcery.com \
--to=nathan@codesourcery.com \
--cc=dan@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox