From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13924 invoked by alias); 29 Nov 2006 13:52:06 -0000 Received: (qmail 13914 invoked by uid 22791); 29 Nov 2006 13:52:04 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 29 Nov 2006 13:51:58 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id kATDptP1173010 for ; Wed, 29 Nov 2006 13:51:55 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.6/8.13.6/NCO v8.1.1) with ESMTP id kATDtX4N3129376 for ; Wed, 29 Nov 2006 14:55:33 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id kATDptbg032158 for ; Wed, 29 Nov 2006 14:51:55 +0100 Received: from [9.152.248.39] (dyn-9-152-248-39.boeblingen.de.ibm.com [9.152.248.39]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id kATDpsWu032146 for ; Wed, 29 Nov 2006 14:51:55 +0100 Message-ID: <456D9076.2000806@de.ibm.com> Date: Wed, 29 Nov 2006 13:52:00 -0000 From: Markus Deuling User-Agent: Thunderbird 1.5.0.8 (X11/20061107) MIME-Version: 1.0 To: GDB Subject: Re: Patch: Little improvement to delete breakpoint command Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00381.txt.bz2 Hi, I renewed the patch and ran the testsuite with an without it: without (gdb 6-5 vanilla) # of expected passes 11033 # of unexpected failures 58 with the patch # of expected passes 11037 # of unexpected failures 54 =============================================================== diff -urN gdb-6.5/gdb/breakpoint.c gdb-6.5_dev/gdb/breakpoint.c --- gdb-6.5/gdb/breakpoint.c 2006-05-01 18:38:08.000000000 +0200 +++ gdb-6.5_dev/gdb/breakpoint.c 2006-11-29 13:44:43.000000000 +0100 @@ -6959,7 +6959,10 @@ b->type != bp_thread_event && b->type != bp_overlay_event && b->number >= 0) + { breaks_to_delete = 1; + break; + } } /* Ask user only if there are some breakpoints to delete. */ Is that ok ? Regards, Markus -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com