From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27307 invoked by alias); 29 Nov 2006 08:33:12 -0000 Received: (qmail 27294 invoked by uid 22791); 29 Nov 2006 08:33:10 -0000 X-Spam-Check-By: sourceware.org Received: from out002.atlarge.net (HELO out002.atlarge.net) (129.41.63.60) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 29 Nov 2006 08:33:05 +0000 Received: from hpmailfe-01.atlarge.net ([10.100.60.156]) by out002.atlarge.net with Microsoft SMTPSVC(6.0.3790.1830); Wed, 29 Nov 2006 02:31:22 -0600 Received: from [172.19.32.122] ([213.250.36.225]) by hpmailfe-01.atlarge.net with Microsoft SMTPSVC(6.0.3790.1830); Wed, 29 Nov 2006 02:31:22 -0600 Message-ID: <456D45BA.9090906@telargo.com> Date: Wed, 29 Nov 2006 08:33:00 -0000 From: Tom Marn Reply-To: tom.marn@telargo.com User-Agent: Thunderbird 1.5.0.8 (X11/20061115) MIME-Version: 1.0 To: Tom Marn , gdb-patches@sourceware.org, matej.kupljen@telargo.com Subject: Re: PATCH: stfiwx implementation for PowerPC gdb simulator References: <45642EC1.2070709@telargo.com> <20061128160737.GF17349@nevyn.them.org> In-Reply-To: <20061128160737.GF17349@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00370.txt.bz2 Daniel Jacobowitz wrote: > I would review this patch, except that I have no idea whether it's > correct. I hope someone more familiar with PowerPC is able to look > at it. > Thank you Daniel The instruction is the same as stfdx except that the stfiwx has effect only on lower 4 bytes instead of full 8 (as stfdx) My reference for that instruction: http://publib.boulder.ibm.com/infocenter/pseries/v5r3/index.jsp?topic=/com.ibm.aix.aixassem/doc/alangref/stfiwx.htm and also: the code for stfdx in gdb/sim/ppc/ppc-instructions file > I'd recommend not moving the instruction; I believe the comments are > section references to the manual from which the pseudocode came > originally. > I agree not moving the location of implementation but: At first, I did implement the instruction on comment out section but I had a problems with dynamic code generator (i don't know why there is not appropriate place), code just won't compile. If someone has a better knowledge about code locations inside ppc-instructions also this could be corrected. It is also strange that only this instruction is left out (or forgotten), all others "optional PowerPC instructions" are implemented. Instead of this instruction the illegal instruction exception is raised, but also in linux kernel there is no implementation. I think that the problem becomes more and more obvious (this year i think) when GCC starts to generate the binaries with this instruction. The same thing is in the QEMU, guess what, also this instruction is missing, where I'm also trying to implement stfiwx instruction. But this is for QEMU mailing list, where i also saw your contributions, maybe we could fix this problem together. Tom Marn