From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9932 invoked by alias); 28 Nov 2006 17:53:41 -0000 Received: (qmail 9922 invoked by uid 22791); 28 Nov 2006 17:53:40 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate2.de.ibm.com (HELO mtagate2.de.ibm.com) (195.212.29.151) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 28 Nov 2006 17:53:34 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate2.de.ibm.com (8.13.8/8.13.8) with ESMTP id kASHrRqV032850 for ; Tue, 28 Nov 2006 17:53:30 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.6/8.13.6/NCO v8.1.1) with ESMTP id kASHv3TZ2629768 for ; Tue, 28 Nov 2006 18:57:03 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id kASHrQs2028738 for ; Tue, 28 Nov 2006 18:53:26 +0100 Received: from [9.152.248.39] (dyn-9-152-248-39.boeblingen.de.ibm.com [9.152.248.39]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id kASHrQc1028734; Tue, 28 Nov 2006 18:53:26 +0100 Message-ID: <456C7791.6070807@de.ibm.com> Date: Tue, 28 Nov 2006 17:53:00 -0000 From: Markus Deuling User-Agent: Thunderbird 1.5.0.8 (X11/20061107) MIME-Version: 1.0 To: Daniel Jacobowitz , GDB Subject: Re: Patch: Little improvement to delete breakpoint command References: <456C7023.4050204@de.ibm.com> <20061128172458.GH21834@nevyn.them.org> <456C7350.7080002@de.ibm.com> <20061128174246.GA23830@nevyn.them.org> In-Reply-To: <20061128174246.GA23830@nevyn.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00336.txt.bz2 Hello, Daniel Jacobowitz schrieb: > On Tue, Nov 28, 2006 at 06:35:12PM +0100, Markus Deuling wrote: >> I did test it and it works for me. > > Did you run the testsuite? Or experiment with any case that should set > breaks_to_delete but not for the most recent breakpoint? > >> The braces are included in vanilla gdb-6.5. Without that "break" the >> braces are unnecessary. This is the original routine: >> >> ALL_BREAKPOINTS (b) >> { >> if (b->type != bp_call_dummy && >> b->type != bp_shlib_event && >> b->type != bp_thread_event && >> b->type != bp_overlay_event && >> b->number >= 0) >> breaks_to_delete = 1; >> } > > Wrong braces. You've converted that to: > > ALL_BREAKPOINTS (b) > { > if (b->type != bp_call_dummy && > b->type != bp_shlib_event && > b->type != bp_thread_event && > b->type != bp_overlay_event && > b->number >= 0) > breaks_to_delete = 1; > break; > } > > Now do you see the problem? Remember, C is not whitespace sensitive. > You are right, sorry, silly mistake from me :-( This should work: --- breakpoint.old 2006-11-28 18:47:43.000000000 +0100 +++ breakpoint.c 2006-11-28 18:50:58.000000000 +0100 @@ -6959,7 +6959,10 @@ b->type != bp_thread_event && b->type != bp_overlay_event && b->number >= 0) - breaks_to_delete = 1; + { + breaks_to_delete = 1; + break; + } } /* Ask user only if there are some breakpoints to delete. */ Regards, Markus -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com