From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-46329-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 28831 invoked by alias); 28 Nov 2006 17:35:33 -0000
Received: (qmail 28817 invoked by uid 22791); 28 Nov 2006 17:35:32 -0000
X-Spam-Check-By: sourceware.org
Received: from mtagate3.de.ibm.com (HELO mtagate3.de.ibm.com) (195.212.29.152)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 28 Nov 2006 17:35:21 +0000
Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) 	by mtagate3.de.ibm.com (8.13.8/8.13.8) with ESMTP id kASHZHWt098892 	for <gdb-patches@sourceware.org>; Tue, 28 Nov 2006 17:35:17 GMT
Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) 	by d12nrmr1607.megacenter.de.ibm.com (8.13.6/8.13.6/NCO v8.1.1) with ESMTP id kASHcsXp2334868 	for <gdb-patches@sourceware.org>; Tue, 28 Nov 2006 18:38:54 +0100
Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) 	by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id kASHZHKv012571 	for <gdb-patches@sourceware.org>; Tue, 28 Nov 2006 18:35:17 +0100
Received: from [9.152.248.39] (dyn-9-152-248-39.boeblingen.de.ibm.com [9.152.248.39]) 	by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id kASHZGo2012553; 	Tue, 28 Nov 2006 18:35:16 +0100
Message-ID: <456C7350.7080002@de.ibm.com>
Date: Tue, 28 Nov 2006 17:35:00 -0000
From: Markus Deuling <deuling@de.ibm.com>
User-Agent: Thunderbird 1.5.0.8 (X11/20061107)
MIME-Version: 1.0
To: GDB <gdb-patches@sourceware.org>
CC: Daniel Jacobowitz <drow@false.org>
Subject: Re: Patch: Little improvement to delete breakpoint command
References: <456C7023.4050204@de.ibm.com> <20061128172458.GH21834@nevyn.them.org>
In-Reply-To: <20061128172458.GH21834@nevyn.them.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2006-11/txt/msg00333.txt.bz2

Hello,

Daniel Jacobowitz schrieb:
> On Tue, Nov 28, 2006 at 06:21:39PM +0100, Markus Deuling wrote:
>> Hello,
>>
>> this little patch adds a break to the loop that is looking for 
>> breakpoints to delete in delete_command(). I think it is only necessary 
>> to find one breakpoint, there is no need to iterate further if found one.
>>
>> ===================================================================
>> --- breakpoint.old      2006-11-28 17:08:11.000000000 +0100
>> +++ breakpoint.c        2006-11-28 17:42:15.000000000 +0100
>> @@ -6960,6 +6960,7 @@
>>             b->type != bp_overlay_event &&
>>             b->number >= 0)
>>           breaks_to_delete = 1;
>> +         break;
>>        }
>>
>>        /* Ask user only if there are some breakpoints to delete.  */
>>
> 
> Did you test this?  I'm pretty sure you're missing braces.
> 

I did test it and it works for me.

The braces are included in vanilla gdb-6.5. Without that "break" the 
braces are unnecessary. This is the original routine:

       ALL_BREAKPOINTS (b)
       {
         if (b->type != bp_call_dummy &&
             b->type != bp_shlib_event &&
             b->type != bp_thread_event &&
             b->type != bp_overlay_event &&
             b->number >= 0)
           breaks_to_delete = 1;
       }


Regards,
Markus