From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23977 invoked by alias); 28 Nov 2006 16:06:48 -0000 Received: (qmail 23966 invoked by uid 22791); 28 Nov 2006 16:06:47 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 28 Nov 2006 16:06:40 +0000 Received: (qmail 11100 invoked from network); 28 Nov 2006 16:06:37 -0000 Received: from unknown (HELO ?192.168.189.103?) (nathan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 28 Nov 2006 16:06:37 -0000 Message-ID: <456C5E87.1060301@codesourcery.com> Date: Tue, 28 Nov 2006 16:06:00 -0000 From: Nathan Sidwell User-Agent: Thunderbird 1.5.0.8 (X11/20061115) MIME-Version: 1.0 To: Nathan Sidwell , gdb-patches@sourceware.org Subject: Re: Fix gdb.base/define.exp References: <456551AE.6020604@codesourcery.com> <20061128151736.GC17349@nevyn.them.org> In-Reply-To: <20061128151736.GC17349@nevyn.them.org> Content-Type: multipart/mixed; boundary="------------090209060906090705070900" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00314.txt.bz2 This is a multi-part message in MIME format. --------------090209060906090705070900 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 373 Daniel Jacobowitz wrote: > OK. If you want, actually call the function somewhere; some compilers > (like ARM's I think?) default to the equivalent of --gc-sections. Good idea. Here's what I committed nathan -- Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery nathan@codesourcery.com :: http://www.planetfall.pwp.blueyonder.co.uk --------------090209060906090705070900 Content-Type: text/x-patch; name="break.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="break.patch" Content-length: 1461 Index: ChangeLog =================================================================== RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v retrieving revision 1.1281 diff -c -3 -p -r1.1281 ChangeLog *** ChangeLog 28 Nov 2006 15:16:47 -0000 1.1281 --- ChangeLog 28 Nov 2006 16:03:34 -0000 *************** *** 1,4 **** ! 2006-11-28 Nathan Sidwell * gdb.threads/linux-dp.exp: Read thread table before and after creating each philosopher and verify it. --- 1,6 ---- ! 2006-11-27 Nathan Sidwell ! ! * gdb.base/break.c (main): Call malloc. * gdb.threads/linux-dp.exp: Read thread table before and after creating each philosopher and verify it. Index: gdb.base/break.c =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/break.c,v retrieving revision 1.5 diff -c -3 -p -r1.5 break.c *** gdb.base/break.c 13 Jun 2006 08:46:17 -0000 1.5 --- gdb.base/break.c 28 Nov 2006 16:03:34 -0000 *************** char *argv[], **envp; *** 87,92 **** --- 87,96 ---- set_debug_traps(); /* set breakpoint 5 here */ breakpoint(); #endif + /* We're used by a test that requires malloc, so make sure it is + in the executable. */ + (void)malloc (1); + if (argc == 12345) { /* an unlikely value < 2^16, in case uninited */ /* set breakpoint 6 here */ fprintf (stderr, "usage: factorial \n"); return 1; --------------090209060906090705070900--