From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21580 invoked by alias); 11 Nov 2006 01:21:17 -0000 Received: (qmail 21568 invoked by uid 22791); 11 Nov 2006 01:21:17 -0000 X-Spam-Check-By: sourceware.org Received: from hq.tensilica.com (HELO mailapp.tensilica.com) (65.205.227.29) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 11 Nov 2006 01:21:11 +0000 Received: from localhost ([127.0.0.1]) by mailapp.tensilica.com with esmtp (Exim 4.34) id 1GihYS-0000xi-S1; Fri, 10 Nov 2006 17:21:09 -0800 Received: from mailapp.tensilica.com ([127.0.0.1]) by localhost (mailapp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 02914-10; Fri, 10 Nov 2006 17:21:08 -0800 (PST) Received: from maxim_fc3.hq.tensilica.com ([192.168.11.68]) by mailapp.tensilica.com with esmtp (Exim 4.34) id 1GihYR-0000xR-RP; Fri, 10 Nov 2006 17:21:07 -0800 Message-ID: <45552583.8070206@hq.tensilica.com> Date: Sat, 11 Nov 2006 01:21:00 -0000 From: Maxim Grigoriev User-Agent: Thunderbird 1.5 (X11/20051201) MIME-Version: 1.0 To: Maxim Grigoriev , gdb-patches@sources.redhat.com, Bob Wilson , Marc Gauthier , Chris Zankel Subject: Re: Xtensa GDB port -- revised patch References: <451B202C.3090804@hq.tensilica.com> <20060928011910.GA20142@nevyn.them.org> <45259B4B.3010101@hq.tensilica.com> <20061110203908.GC1115@nevyn.them.org> In-Reply-To: <20061110203908.GC1115@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00077.txt.bz2 Hi Daniel, Thank you very much for finding the time to review Xtensa submission. > - The port needs a maintainer, and an entry in MAINTAINERS. Who will > be the maintainer? > I'd be happy to become an Xtensa GDB maintainer. I have a question about the second issue you pointed to: > - I noticed that your prev_register recursively calls > frame_register_unwind. This isn't a big problem but it is > incorrect. If you defer to another frame, you should set > e.g. realnump to point the number for the next frame. See > trad_frame_get_prev_register for an example. > I understood your concern is that the register number within the next frame is not set ( *realnump ). On Xtensa, it's going to be unchanged from the previous frame's value. Question: is replacing of frame_register_unwind (next_frame, regnum, optimizedp, lvalp, addrp, realnump, valuep); with *optimizedp = 0; *lvalp = lval_register; *addrp = 0; *realnump = regnum; if (valuep) frame_unwind_register (next_frame, (*realnump), valuep); the fix you are looking for ? I tested it. It works fine. And, I fixed the rest of issues ( sorry for missing that ) : > - There's one stray hunk: > >> @@ -1330,7 +1332,6 @@ >> done >> >> Makefile: Makefile.in config.status @frags@ >> - # Regenerate the Makefile and the tm.h / nm.h links. >> CONFIG_FILES=Makefile \ >> > - There's a few instances of operators without spaces around them, > like "-=4" and "(op1)==0x6c" and "8? 8". I don't think you need to > go back and fix them at this point, but please be careful in the > future. > -- Maxim