From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59321 invoked by alias); 10 Jul 2018 04:36:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59307 invoked by uid 89); 10 Jul 2018 04:36:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Jul 2018 04:36:03 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 5B5F81E059; Tue, 10 Jul 2018 00:36:02 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531197362; bh=2+fEd2JkyYaJLKVr2genU4GeFB/ioFQ1c0ZGqDAn3yo=; h=Subject:To:References:From:Date:In-Reply-To:From; b=UmItvD961IDqwnpslN4VJeevmcen7K/Cv9bibkmTI5uNPDevp4FteHwAAb7r0t0kv V0Klk6XAjFuamHVA8cZ6H5ltgHY7dbgkesdkhU282C6m5pkqS2MSRXSqRULM2odqy8 H+UK/KD/c6KKaMXY2W16b/bCOkwwtTQGRLATiArM= Subject: Re: [RFA 40/42] Convert the DWARF reader to new-style buildysm To: Tom Tromey , gdb-patches@sourceware.org References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-41-tom@tromey.com> From: Simon Marchi Message-ID: <4545baa1-c8e3-5933-489a-7981e0e624ef@simark.ca> Date: Tue, 10 Jul 2018 04:36:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180523045851.11660-41-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00258.txt.bz2 Just some nits, otherwise it LGTM. On 2018-05-23 12:58 AM, Tom Tromey wrote: > @@ -11129,12 +11139,12 @@ read_namespace_alias (struct die_info *die, struct dwarf2_cu *cu) > global only in Ada. */ > > static struct using_direct ** > -using_directives (enum language language) > +using_directives (struct dwarf2_cu *cu) The comment above would need to be updated. > @@ -11578,7 +11588,13 @@ setup_type_unit_groups (struct die_info *die, struct dwarf2_cu *cu) > else > { > gdb_assert (tu_group->symtabs == NULL); > - restart_symtab (tu_group->compunit_symtab, "", 0); > + gdb_assert (!bool (cu->builder)); That looks odd, can't you do the usual gdb_assert (cu->builder == nullptr) ? There are other instances of this. > @@ -24200,6 +24237,7 @@ dwarf_parse_macro_header (const gdb_byte **opcode_definitions, > > static void > dwarf_decode_macro_bytes (struct dwarf2_per_objfile *dwarf2_per_objfile, > + struct dwarf2_cu *cu, > bfd *abfd, > const gdb_byte *mac_ptr, const gdb_byte *mac_end, > struct macro_source_file *current_file, You can probably remove the dwarf2_per_objfile parameter, since it's< available as: struct dwarf2_per_objfile *dwarf2_per_objfile = cu->per_cu->dwarf2_per_objfile; Simon