From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 498 invoked by alias); 19 Oct 2006 09:47:01 -0000 Received: (qmail 489 invoked by uid 22791); 19 Oct 2006 09:47:00 -0000 X-Spam-Check-By: sourceware.org Received: from lon-del-01.spheriq.net (HELO lon-del-01.spheriq.net) (195.46.50.97) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 19 Oct 2006 09:46:51 +0000 Received: from lon-out-03.spheriq.net ([195.46.50.131]) by lon-del-01.spheriq.net with ESMTP id k9J9kkVD030744 for ; Thu, 19 Oct 2006 09:46:47 GMT Received: from lon-cus-01.spheriq.net (lon-cus-01.spheriq.net [195.46.50.37]) by lon-out-03.spheriq.net with ESMTP id k9J9kjjW031589 for ; Thu, 19 Oct 2006 09:46:46 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by lon-cus-01.spheriq.net with ESMTP id k9J9khWu005893 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK); Thu, 19 Oct 2006 09:46:44 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 6E8F0DA44; Thu, 19 Oct 2006 09:46:43 +0000 (GMT) Received: from mail1.bri.st.com (mail1.bri.st.com [164.129.8.218]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id F2284472FB; Thu, 19 Oct 2006 09:46:42 +0000 (GMT) Received: from [164.129.15.13] (bri1043.bri.st.com [164.129.15.13]) by mail1.bri.st.com (MOS 3.5.8-GR) with ESMTP id CIC83248 (AUTH stubbsa); Thu, 19 Oct 2006 10:46:41 +0100 (BST) Message-ID: <45374981.5080304@st.com> Date: Thu, 19 Oct 2006 09:47:00 -0000 From: Andrew STUBBS User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) MIME-Version: 1.0 To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Don't give spurious warnings when using thread specific breakpoints References: <452CF534.4060209@st.com> <20061011135545.GA26060@nevyn.them.org> <452D0385.6010103@st.com> <20061011204525.GA9622@nevyn.them.org> <45361793.1020202@st.com> <20061018141419.GA7771@nevyn.them.org> <4536444C.9020709@st.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00240.txt.bz2 Eli Zaretskii wrote: >> If a specific language can't do something useful with it they can just >> leave it as " and" they've lost nothing. > > Aha, and now imagine that you've been handed a program that generally > displays English messages, but sometimes says "and" in Chinese, say. > Would you be very happy? Please note that this is not a preposterous > example: many people in many countries _really_ don't know English > very well, even though they are programmers. My point was that what it _currently_ does is just put 'and' with no option for the translator to change it, so if we give them the option to translate but they can't use it then they've lost nothing. Other languages have gained something. Of course, if they are translating without any reference to the context in which it is displayed, and without being programmers, then I suspect the translation would read rather like a Chinese road sign. > No, you don't need to do that. Instead, you should rewrite the code > like this: > > ALL_BREAKPOINTS (b) > if (b->loc->address == pc) /* address match / overlay match */ > if (!b->pending && (!overlay_debugging || b->loc->section == section)) > { > others--; > if (others == 1 && > (b->enable_state == bp_disabled || > b->enable_state == bp_shlib_disabled || > b->enable_state == bp_call_disabled)) > printf_filtered (_("Note: breakpoint %d (disabled) also set at pc "), > b->number); > } > deprecated_print_address_numeric (pc, 1, gdb_stdout); > printf_filtered (".\n"); > > and similarly for the other combinations of the inline conditionals. > No, you misunderstand the code. There can be an arbitrary number breakpoints, each of which can have zero, one or two annotations, and they are all presented as one message. Andrew