From: Andrew STUBBS <andrew.stubbs@st.com>
To: GDB Patches <gdb-patches@sourceware.org>
Subject: [PATCH] long long for printf on MinGW
Date: Wed, 11 Oct 2006 11:21:00 -0000 [thread overview]
Message-ID: <452CCE2D.8070806@st.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 332 bytes --]
Hi,
Windows/MinGW printf does support printing of long long types, but it
does not do using %lld etc.
This patch converts %ll (or %...ll) to %I64 as required by Windows.
GDB printf still won't accept I64 as input, but then this is not
standard compliant so I don't think it really should.
:ADDPATCH printcmd.c:
Andrew Stubbs
[-- Attachment #2: printf.patch --]
[-- Type: text/plain, Size: 1673 bytes --]
2006-10-11 Andrew Stubbs <andrew.stubbs@st.com>
* printcmd.c (printf_command): Convert %lld to %I64d on MinGW.
Index: src/gdb/printcmd.c
===================================================================
--- src.orig/gdb/printcmd.c 2006-07-17 23:15:55.000000000 +0100
+++ src/gdb/printcmd.c 2006-10-11 11:28:29.000000000 +0100
@@ -1967,8 +1967,24 @@ printf_command (char *arg, int from_tty)
*f);
f++;
- strncpy (current_substring, last_arg, f - last_arg);
- current_substring += f - last_arg;
+#if defined (__MINGW32__)
+ /* Windows' printf does support long long, but not the usual way.
+ Convert %lld to %I64d. */
+ if (lcount > 1)
+ {
+ int length_before_ll = f - last_arg - 1 - lcount;
+ strncpy (current_substring, last_arg, length_before_ll);
+ strcpy (current_substring + length_before_ll, "I64");
+ current_substring[length_before_ll + 3] =
+ last_arg[length_before_ll + lcount];
+ current_substring += length_before_ll + 4;
+ }
+ else
+#endif
+ {
+ strncpy (current_substring, last_arg, f - last_arg);
+ current_substring += f - last_arg;
+ }
*current_substring++ = '\0';
last_arg = f;
argclass[nargs_wanted++] = this_argclass;
@@ -2056,7 +2072,8 @@ printf_command (char *arg, int from_tty)
error (_("long double not supported in printf"));
#endif
case long_long_arg:
-#if defined (CC_HAS_LONG_LONG) && defined (PRINTF_HAS_LONG_LONG)
+#if defined (CC_HAS_LONG_LONG) && (defined (PRINTF_HAS_LONG_LONG) \
+ || defined (__MINGW32__))
{
long long val = value_as_long (val_args[i]);
printf_filtered (current_substring, val);
next reply other threads:[~2006-10-11 11:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-11 11:21 Andrew STUBBS [this message]
2006-10-11 13:03 ` Daniel Jacobowitz
2006-10-11 15:12 ` Andrew STUBBS
2008-04-22 19:41 ` Daniel Jacobowitz
2008-04-23 10:26 ` Andrew STUBBS
2008-04-23 12:18 ` Daniel Jacobowitz
2008-04-23 16:12 ` Andrew STUBBS
2006-10-11 20:28 ` Mark Kettenis
2006-10-11 20:44 ` Daniel Jacobowitz
2006-10-12 10:09 ` Andrew STUBBS
[not found] ` <200610151745.k9FHjvPa017960@elgar.sibelius.xs4all.nl>
2006-10-16 9:45 ` Andrew STUBBS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=452CCE2D.8070806@st.com \
--to=andrew.stubbs@st.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox