From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Qa0FKxXCK2Zj5TwAWB0awg (envelope-from ) for ; Fri, 26 Apr 2024 11:02:45 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Nz4piTrO; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9B6A01E0CE; Fri, 26 Apr 2024 11:02:45 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7BF821E0C0 for ; Fri, 26 Apr 2024 11:02:43 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CB3F0384A880 for ; Fri, 26 Apr 2024 15:02:42 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 254433858C50 for ; Fri, 26 Apr 2024 15:02:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 254433858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 254433858C50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714143733; cv=none; b=lgCydaqXYnjV7/kDjGmrI9yG4DYHEkLaxydJqvAFLz8GuMMMySANbtuStUfeoR78gdtiYpyv0mrHsdWb7HvsLXDwBZAbGGJLlqqv/7BjMrW08kqIxdh2XYD1zME/3nmduXAhTobB4hjwc9aJZV8MD05fBT8nLW8YnEeZoZdKHz4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714143733; c=relaxed/simple; bh=yiDzReFTmgjZxtx1m91e3vf+gpkAFF+f6tQHfUKZzwM=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=s++Lax+qgfJdQKtsRENmp5DNr39F3ANPsiDYUSVFaLATuUfdu4MVQ73l3hSbyRlfHdExHJ1yCgfQpHv/cazeHmLiu5828U5DjJrqHB38taqwGYD0x6HBhKjIA8ncuBFREFYvsHvmyCKzvgmprTW7K1+OGZze8/+DumUjhHxNNfo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714143724; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V7chVvtsT4dVQU68UMOmv7bwIEBZAGYP8/qlIwi8Dzs=; b=Nz4piTrO6qboy1PBhE0Yf8p5znHBde8x4daxD+4yKu8CqO5dEeXDVPbNKPq32UY9z2FGuy Ytc8nCGvRp+nE2P/wfOUAceXk5gdevEcj4Wb2nPtMV+LRYeSkk6s62bgsrnE2n3eX7fELN YQENOS///47qjmiT/6+IDOtrCgvsMb0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-140-LEgTEd5ZM1W7-k2KG0370w-1; Fri, 26 Apr 2024 11:02:03 -0400 X-MC-Unique: LEgTEd5ZM1W7-k2KG0370w-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-41ab62f535aso10538995e9.0 for ; Fri, 26 Apr 2024 08:02:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714143721; x=1714748521; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V7chVvtsT4dVQU68UMOmv7bwIEBZAGYP8/qlIwi8Dzs=; b=ct4pMlyFrWnkiguJ6Sxr1W9Nh9mN8kZgHvqegtwEH2Z95LEa9zurMWmNSySlFVRO5v XqEgd7DFBonnU/DZq1S6iH5Mq+Mu1akl3IZJfzSzugChfPs7XJ5wuyOcgyyFeqyI+xJT OJ6PJUAVDLDK0gQgyCGIaN1VqkWI4jlVRjFh/PnGU2d84L+mHt5S482/v/RxYypjpzcf a/Mc2W86DjJo6R2DruRNgqh0ro1fGljGUUZmFiQPV/X7mvjtm3LQs+cOcqc+sSJoSqiA gGR+GFtWBeWrRECSXlItjoqjUCsMP034Uq3Yy/BSsA3z1xIaYLFnt6rjhQ4nv9712H9Z cLBQ== X-Gm-Message-State: AOJu0YxlA13y/Aa7HaUffFIUpBxsZaTgEZYRtqCyCj6KCytJl6X2NhOn 9n6tsrRY+mbvSCIfWn9I5pMrYGj5y+U2hoFiz8iSaj7s2oMjIGtOsxYpT2PPs9w1nHTuno0BNzI AnPHpaUaTBQ7zYZ4d/kTVFnzoC5zvJiSeZOl8dU7W+xU+AV7xe7k64YJkhwhxQwRQIf1Tjaj6ax yHqx0hqJDxbk8vmpAyBozCYU79OsMSkYb5uoeoGKVjahk= X-Received: by 2002:a05:600c:35c3:b0:41a:7bbe:c3bf with SMTP id r3-20020a05600c35c300b0041a7bbec3bfmr39980wmq.22.1714143721093; Fri, 26 Apr 2024 08:02:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHpTQ12N0QlLN1ljHd52FANss38F8dRekaH0G9U/JVqltSc2EJXME262S8qLyIV6bnjvusshA== X-Received: by 2002:a05:600c:35c3:b0:41a:7bbe:c3bf with SMTP id r3-20020a05600c35c300b0041a7bbec3bfmr39940wmq.22.1714143720429; Fri, 26 Apr 2024 08:02:00 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id j2-20020a05600c1c0200b0041ac3e13f1esm12952471wms.37.2024.04.26.08.01.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Apr 2024 08:01:58 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess , felix.willgerodt@intel.com, John Baldwin Subject: [PATCHv5 01/11] gdbserver/ipa/x86: remove unneeded declarations Date: Fri, 26 Apr 2024 16:01:45 +0100 Message-Id: <451f76b4ea105af2def7e62d78662a647e809e73.1714143669.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Spotted some declarations in gdbserver/linux-amd64-ipa.cc that are no longer needed. These are: 1. 'init_registers_amd64_linux' - the comment claims this function is auto generated, but I don't believe that this is still the case. Also the function is not used in this file, 2. 'tdesc_amd64_linux' - this variable doesn't seem to exist any more, I suspect this was renamed to 'tdesc_amd64_linux_no_xml', but neither are used in this file, so lets remove the declaration. The amd64 in-process-agent still builds fine after this commit. There should be no user visible changes after this commit. --- gdbserver/linux-amd64-ipa.cc | 4 ---- 1 file changed, 4 deletions(-) diff --git a/gdbserver/linux-amd64-ipa.cc b/gdbserver/linux-amd64-ipa.cc index 13c8a5bb360..a6346750f49 100644 --- a/gdbserver/linux-amd64-ipa.cc +++ b/gdbserver/linux-amd64-ipa.cc @@ -23,10 +23,6 @@ #include "linux-x86-tdesc.h" #include "gdbsupport/x86-xstate.h" -/* Defined in auto-generated file amd64-linux.c. */ -void init_registers_amd64_linux (void); -extern const struct target_desc *tdesc_amd64_linux; - /* fast tracepoints collect registers. */ #define FT_CR_RIP 0 -- 2.25.4