From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cBlHAidsYGEaGAAAWB0awg (envelope-from ) for ; Fri, 08 Oct 2021 12:04:55 -0400 Received: by simark.ca (Postfix, from userid 112) id 06D1A1EE20; Fri, 8 Oct 2021 12:04:55 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9E60E1ECEB for ; Fri, 8 Oct 2021 12:04:53 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1B76A3858412 for ; Fri, 8 Oct 2021 16:04:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1B76A3858412 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1633709093; bh=HYXiKhFdtWDnhzUMi2WZ8/eZwSFTbiLy8MTVVg+CKxI=; h=To:Subject:Date:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=p2QTVYj1yyHAkH+2XWJgJxZY7QsQ8rcIPkpjKFy+f7hVk2Z4gQ+hPSypTPGJONlZT fvlSYCFSjBpC6sHDrvLBwLZ9GmbEX0jtPWXsc/35tlu2uECnqMl2296SnM1hnee6cn MCudAcf/xJISXqBFrk5FVof9MvLh7fW5lnN2hxqQ= Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2085.outbound.protection.outlook.com [40.107.22.85]) by sourceware.org (Postfix) with ESMTPS id 136E13858D39 for ; Fri, 8 Oct 2021 16:04:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 136E13858D39 Received: from AM5PR0701CA0064.eurprd07.prod.outlook.com (2603:10a6:203:2::26) by AM8PR08MB5652.eurprd08.prod.outlook.com (2603:10a6:20b:1d8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Fri, 8 Oct 2021 16:04:05 +0000 Received: from AM5EUR03FT054.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:2:cafe::a6) by AM5PR0701CA0064.outlook.office365.com (2603:10a6:203:2::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.4 via Frontend Transport; Fri, 8 Oct 2021 16:04:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT054.mail.protection.outlook.com (10.152.16.212) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend Transport; Fri, 8 Oct 2021 16:04:05 +0000 Received: ("Tessian outbound a8bfe25d7364:v103"); Fri, 08 Oct 2021 16:04:04 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 8345af7e95ad2997 X-CR-MTA-TID: 64aa7808 Received: from fb5413a1fd4b.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3C468461-CE4C-47D3-AEA8-F96AE7DC2B0B.1; Fri, 08 Oct 2021 16:03:59 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fb5413a1fd4b.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 Oct 2021 16:03:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dED+Dy+t3tIhcLMq+HxXOLFNgEJ1AnzOy//NI0xHdvovpwsj14vYFqSDQQLNPq4xy/DP1CCokGVQnXHOU9O6AbbeV3/QbGbrpBHVgq8sYiGDgI8nTh2CXFnT6wE4mklLzM367+5rbDSj1EQlpoOZx6+NsAJMS2s/SCu4uT6IIOmaQwSgoZmFkBSDHHwSxXHMc4LfvSO9fhfLseQVA60ZTI9LWZvhubVFi+wEwEywX4AxpjFc9rznwwJf64lgQ/s1N68aJIA4hDafMjPuH9+ls00h0KBO7qTTW9heOC0IwBwe4x0H3uAKDa18+urjtnI3/UZpKANYDDcBGvxGv02Z9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HYXiKhFdtWDnhzUMi2WZ8/eZwSFTbiLy8MTVVg+CKxI=; b=MxwHCNfjX4CxncSiY40dmlgDHDyJuYQdjCJBzPtAp+QhEBzUySzopFPSnPFo7PeUTlj67eVz7EfDDfRE5ey9nqJ6x8ZHZaWRsJ/xg2D0oLGlUQz5Z/sp8w01l27DI8SiSipJ9glSWbowAKx9fes3mKKhSSF+TkXTRUMmqsVRepKqC8EHPpWib3vf27LfkAQhJgqzPjYIHt7HBKBbFl+QwlhzEeUZxsVp3U7cDtohOKoO1cJwrt1tBOWdiYm74Ki++DBZo0TWW72I3uv66TyoO88ZP+86bZXIROALI4LQBzXXIb3tXON511Lp8f2NRyFkH31dcZ3mcVt6xHvYm+ID0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from AM6PR08MB3957.eurprd08.prod.outlook.com (2603:10a6:20b:a2::14) by AS8PR08MB6709.eurprd08.prod.outlook.com (2603:10a6:20b:395::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Fri, 8 Oct 2021 16:03:57 +0000 Received: from AM6PR08MB3957.eurprd08.prod.outlook.com ([fe80::5d0c:6e21:5ba3:ff8e]) by AM6PR08MB3957.eurprd08.prod.outlook.com ([fe80::5d0c:6e21:5ba3:ff8e%6]) with mapi id 15.20.4566.022; Fri, 8 Oct 2021 16:03:57 +0000 To: Luis Machado Subject: Re: [PATCH 2/4] [ARM] Small refactoring of arm gdbarch initialization Thread-Topic: [PATCH 2/4] [ARM] Small refactoring of arm gdbarch initialization Thread-Index: AQHXufe22trlND6DnEu6hEEU5zBjx6vJSEOA Date: Fri, 8 Oct 2021 16:03:57 +0000 Message-ID: <451AA8F6-E7C5-4CD3-AB39-25597ECE6B9A@arm.com> References: <20211005144521.1965198-1-luis.machado@linaro.org> <20211005144521.1965198-3-luis.machado@linaro.org> In-Reply-To: <20211005144521.1965198-3-luis.machado@linaro.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.120.0.1.13) Authentication-Results-Original: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 495bdaa4-7298-4d76-5834-08d98a7540fa x-ms-traffictypediagnostic: AS8PR08MB6709:|AM8PR08MB5652: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: IjeVY51lUhIMqpXfr5WDbjqBk60R5lYehji7UFLS3ZrViSn3jebOiBAxHNNZOEk7GEJp3NlGq0+viPOli95hiUkhrclS/Pey2L8bIbwZvZrINnMWahC3WTt0dwRgcR1RgrWSLGJeU0ifx95LzDSw2t6Zyco7EVTD+QLGzva6JLMxR2TGxwFTNNhEosZ+8akwBpGJB2otSgpDAeZzlbtYoQ8scT1jkMG3Oi0OI4IthSZ/rD20gqEfBsFh7EEVg1OnA22uWD2K6yViPUFmlH/yHNPoLfSf/W4rc2DOMT78S4vgeIUDj/Hlr2BTtuj9rFThoYLgMOUvLF0HPgS2vzWWVVpKwHZIiCs6CtsyKN5j9CBTxm/kSSRKobqIfd1YdBpRuKTO6WbfaE2NZnGtbA608AclfRsP8BCYVgdD12Pu8oxG1lzfHWWlPXJWJA4r2DVKagwF82KSc9pjK19A8x4MRVEf+d0lIX5fDrs8vFTbzBUr6dWwdU6umfUysCPpFTAY1FXiHVQtUdqWWGdHra4Ltzkf5w9gf6G+JsWBQiGg2BpNkO43FUZ1cFzY9TDzgD4r1wZvHN/L2379UXuzKWsIXpc5Bed8iFEA978RnVeeCSWmhmmsBWpFo3nJYaH25Vp1Mp6VMJyWXRItfU8f9oq9SVzpeHrLKmYXXHyDBYw3z+w7wLDUbolLc9mkr0N/T8JZor430Bpb3jNqnhZV3xEdvr5F2pyDXwlBoaKeHh6vP93cUv7hv7knHkfl5Z24lItV X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR08MB3957.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6916009)(316002)(54906003)(6512007)(8676002)(71200400001)(53546011)(91956017)(6506007)(8936002)(26005)(4326008)(76116006)(508600001)(2906002)(5660300002)(66946007)(6486002)(66446008)(66476007)(64756008)(66556008)(186003)(86362001)(122000001)(38100700002)(83380400001)(36756003)(33656002)(38070700005)(2616005)(45980500001); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <84ACC4CC94413B42AFFEA744DBF91734@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6709 Original-Authentication-Results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: f05df1cf-4160-4008-73ce-08d98a753c56 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tRo8pckiYGwAvzT6Geyi3ilWEhzWaYYEU9M/loL2ZBXOYPEvAOsxLWQQlveC58pTNLEopao7Wqg5W3TSa3lUEOeff5qIThxK3iNPBpYjwMmBtTQ5zl+DRZ002napdXObXULnsqDwtieEyDlU4zP93BAEGcIZ6LL6IHzFJJ4FvfF6oRYoMOWazQRsJplzX78azWfG4KIt+kqxK1NWEYi5BFebR/nNhyzmd2rQhQSpUo0MfhOga07Em1cjF1l0HXxqD1qTGhB2004KHkTOCg9Cj1DN5XRxhM8izMwJpMJ7IqwyulL8tA62g2nEpNHekE0IUaAVbOrJtgsmBJnpgKtwzx/9V1ZS9Sy0ziR3pp2+k4A+K71q2B5lk5b/fs3WdTcBEM68OMl8ZYkgU3K6yO7qKTcJ6GEQNeiZyJJRhvY0sJWtHTyFQEdd0xGuR/K90nPWa1O5IAiFGeEwriG1Uq60Ih8hq32log8z7qZpYHLx7/OwFqnGRaWJ8lXTufR+t3AG28/wWosJwSdqkqJdnSVXTS3ZqLlXVi+LtwVKh2M+FKUsiC+VcNN09HOo15YhETojP5Eildot5jRKqyYW61Qaor7by403ar208a7rett7Q30SNCMzAUEu3K9WJ/qPhN+w+x56RLFKUBqjvY75IuUAleUtl79dWDIaeCExmUn/C7wa9o/IJywsDNQyGxgCifk1qyoY7fvihVvmAq2oPPTy1Q== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(336012)(54906003)(70586007)(356005)(70206006)(2616005)(508600001)(186003)(8676002)(26005)(82310400003)(53546011)(6506007)(81166007)(5660300002)(2906002)(86362001)(36756003)(6512007)(36860700001)(4326008)(6486002)(47076005)(33656002)(6862004)(8936002)(83380400001)(316002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 16:04:05.5021 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 495bdaa4-7298-4d76-5834-08d98a7540fa X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5652 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alan Hayward via Gdb-patches Reply-To: Alan Hayward Cc: Peter Maydell , nd , "gdb-patches\\@sourceware.org" Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Lgtm Alan > On 5 Oct 2021, at 15:45, Luis Machado wrote: >=20 > This is in preparation to MVE support, where we will define another > pseudo register. We need to define the pseudo register numbers *after* > accounting for all the registers in the XML description, so move > the call to tdesc_use_registers up. >=20 > If we don't do it, GDB's register count won't consider registers containe= d > in the XML but ignored by GDB, throwing the register numbering off. > --- > gdb/arm-tdep.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) >=20 > diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c > index ab6999ae209..2a6bfb1b3f7 100644 > --- a/gdb/arm-tdep.c > +++ b/gdb/arm-tdep.c > @@ -9470,6 +9470,17 @@ arm_gdbarch_init (struct gdbarch_info info, struct= gdbarch_list *arches) > set_gdbarch_long_double_format (gdbarch, floatformats_ieee_double); > } >=20 > + if (tdesc_data !=3D nullptr) > + { > + set_tdesc_pseudo_register_name (gdbarch, arm_register_name); > + > + tdesc_use_registers (gdbarch, tdesc, std::move (tdesc_data)); > + > + /* Override tdesc_register_type to adjust the types of VFP > + registers for NEON. */ > + set_gdbarch_register_type (gdbarch, arm_register_type); > + } > + > if (have_vfp_pseudos) > { > /* NOTE: These are the only pseudo registers used by > @@ -9484,17 +9495,6 @@ arm_gdbarch_init (struct gdbarch_info info, struct= gdbarch_list *arches) > set_gdbarch_pseudo_register_write (gdbarch, arm_pseudo_write); > } >=20 > - if (tdesc_data !=3D nullptr) > - { > - set_tdesc_pseudo_register_name (gdbarch, arm_register_name); > - > - tdesc_use_registers (gdbarch, tdesc, std::move (tdesc_data)); > - > - /* Override tdesc_register_type to adjust the types of VFP > - registers for NEON. */ > - set_gdbarch_register_type (gdbarch, arm_register_type); > - } > - > /* Add standard register aliases. We add aliases even for those > names which are used by the current architecture - it's simpler, > and does no harm, since nothing ever lists user registers. */ > --=20 > 2.25.1 >=20