From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8HF8MFUSe19QBQAAWB0awg (envelope-from ) for ; Mon, 05 Oct 2020 08:32:21 -0400 Received: by simark.ca (Postfix, from userid 112) id C4B241EE0F; Mon, 5 Oct 2020 08:32:21 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 773A61E58D for ; Mon, 5 Oct 2020 08:32:21 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 01E69381DCE9; Mon, 5 Oct 2020 12:32:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 01E69381DCE9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1601901141; bh=A2FfUFOr4z1WHQ8JK7KRwgariMBQL8KWnrcFcNsO0Lk=; h=Date:To:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=sHXu9NdU66QCcEj5WdrxIrHrwClkevZ6UKudGBt7i9fz6pHGL6mXZTTQFEAgHRBZW q/ZWU7o0W+JJBkXVekXD7eD2/YhrfMR0wKTPUiOqIImE/3cJMoU09zQ6An73pKgzP7 nZDn+aPAzbXpwV7aujETSfqVgBH9e8FF3hCg8AxI= Received: from sonic307-53.consmr.mail.ir2.yahoo.com (sonic307-53.consmr.mail.ir2.yahoo.com [87.248.110.30]) by sourceware.org (Postfix) with ESMTPS id EF6A8381DCE9 for ; Mon, 5 Oct 2020 12:32:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EF6A8381DCE9 X-YMail-OSG: .EEvMb8VM1lC2CTXTj_3QrnO6BMOZtyZcs7NLdDeRvaoo0VL3ypWbVlXCYhBo_V 5_lxrGYRDN_tNpFmFV_sKEHhT2Zy9KLS6j7LwcpS1mqQYdd0_v0KUIJbiHTLZwDn8xYBNt6Jcqeh Mf4gsEVyNvP7pJTUBvLyfb8Iki1NiprxKgXRU7piQon1hfczbjSKLc4mMB47EKYMz_biOplUPpem hoQaNmPdONJ7Wb.jQ.Znxb2y2_C58Y1YpJSFkgzdYv5U.ZR8pULRsQCRDg9BFwBAijwZuzhkwwik M12KS5XRhUjz20zTFR8j4CQ0R8lFyosMpBAvZQFfR9FKMtE3dbaQi9K2By49TSZvkPUjKqiOFlXH UBOkdHs6zG9KuKPOpCuGoMmXv.eBWZqUPSHCFlnyLHc1MGk.zabhPNqoi6QNUsUqVjyI7P3mpyCu FLCrM67Z4XyidVeAc8CDcQt8iDwQVXpgtF6_cWjtmcmHwkf8k82sqghxoSGZJLhW9qzEVgg2.brm az1_2Xg7WLecFZjBKbVmBwzKEPVfc5OjjCKu05FfK4sAbjxtPYUVowGdDkjWhtBEJSEZBuSQbVFm _MHB3SWXjMqAQlVuDvHceF_42zrz0QXfmHhq.K8uXCx7c2sTArlF1lSqDvpjJOZctQHNEOU1Tfwm dJLRxe0SOjIveLRR2Xr6DoL3ZHde.xqJrpn3suRf0Rv7LoMuafBZE5EWODDaa6fVgLYrDS8xYQT2 aghzBXPOnzl9yCrU7FhHWN9jRig7HiIEIjCTQ01_hILyX65LB0i60bxcLXAoadRTscFMBByojFV5 o6V_uIgiKX1MGCJ.5ZYcP1_mNk6Lsu3Y0ROFPHTzdvM5YN5ec45iR7jYv39a2lzyHwB4rXmjqR8K 9NMM00Z.U5aAOg1Ly8RX5.rvKDYTq0mJuTLJ8w581OswPwyNdpV_Tu1D61lUxu2aob3U5G6Vd6Lf 40yj.ZpWyAbfaCQLAg6QxnRfW.wEjooUWdY5oO2txt.NYcoUOrmJHATM_PInfim2Q762FmTV5c6S wBGEC7RQBMv80_utp6Etb5rjapwCyKWuTyHPBkAk6kKLWZpLF9X4Dg3RMd2zAkC7Mw8Oo0Y14_kX PHY52ZIiYXt2DyNXExlQZ8ZNaE8jnc_oOSUMdNvK6Vql0DLFa8VhFb0YhlsxMNQDV88miBU.GXpI OXm_5P.NWbxvmqel2N1f7vXSXR964oZEInsIwXfuRJQIH7j7P0JEcOGCU.Ndq6HDFSkTUKK_qFPD Qx_x9rJAmnpuVA_02e2cuFD9IYlWieCQBraSaCuoTmV0jYbP7Jbh1Hy9xqnSUEcWyXFIaq0GwNTB .DQnABcgYaxyaas3vHxpciGieupoIAe3boe076RHm9zocLWjE.5DhWaHYDv585D5MkY1AS2rtPCT junWpbiq4gqwUh4yVlegZ.k3SsgdGajXgRAZfMXsZ3TTN5rVp3vyWB0_MbnVLTohcy.1gqitPkbG klG5Orw-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ir2.yahoo.com with HTTP; Mon, 5 Oct 2020 12:32:17 +0000 Date: Mon, 5 Oct 2020 12:32:14 +0000 (UTC) To: "gdb-patches@sourceware.org" , Simon Marchi Message-ID: <451412237.3128231.1601901134337@mail.yahoo.com> In-Reply-To: References: <20200529150800.2013-1-ssbssa.ref@yahoo.de> <20200529150800.2013-1-ssbssa@yahoo.de> Subject: Re: [PATCH v2 1/2] Fix function argument and return value locations MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.16718 YMailNorrin Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Hannes Domani via Gdb-patches Reply-To: Hannes Domani Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Am Montag, 5. Oktober 2020, 03:50:20 MESZ hat Simon Marchi Folgendes geschrieben: > On 2020-05-29 11:07 a.m., Hannes Domani via Gdb-patches wrote: > > Fixes these testsuite fails on Windows: > > FAIL: gdb.base/callfuncs.exp: p t_float_complex_values(fc1, fc2) > > FAIL: gdb.base/callfuncs.exp: p t_float_complex_many_args(fc1, fc2, fc3= , fc4, fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4) > > FAIL: gdb.base/callfuncs.exp: noproto: p t_float_complex_values(fc1, fc= 2) > > FAIL: gdb.base/callfuncs.exp: noproto: p t_float_complex_many_args(fc1,= fc2, fc3, fc4, fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4) > > FAIL: gdb.base/call-sc.exp: p/c fun(); call call-sc-tld > > FAIL: gdb.base/call-sc.exp: advance to fun for return; return call-sc-t= ld > > FAIL: gdb.base/call-sc.exp: zed L for return; return call-sc-tld > > FAIL: gdb.base/call-sc.exp: return foo; return call-sc-tld > > FAIL: gdb.base/call-sc.exp: return foo; synchronize pc to main() for 'c= all-sc-tld' > > FAIL: gdb.base/call-sc.exp: return foo; synchronize pc to main() for 'c= all-sc-tld' > > FAIL: gdb.base/call-sc.exp: advance to fun for finish; return call-sc-t= ld > > FAIL: gdb.base/call-sc.exp: zed L for finish; return call-sc-tld > > FAIL: gdb.base/call-sc.exp: finish foo; return call-sc-tld (the program= is no longer running) > > FAIL: gdb.base/call-sc.exp: value foo finished; return call-sc-tld > > > > For function arguments (callfuncs.exp), only TYPE_CODE_COMPLEX was > > missing in the types passed via integer registers. > > > > For return values, there were a lot more issues: > > - TYPE_CODE_DECFLOAT is NOT returned via XMM0. > > - long double is NOT returned via XMM0. > > - but __int128 IS returned via XMM0. > > - the comments for TYPE_CODE_FLT state that __m128, __m128i and __m128d= are > >=C2=A0 returned by XMM0, and this is correct, but it doesn't actually ch= eck for > >=C2=A0 them, because they are TYPE_CODE_ARRAY with TYPE_VECTOR > > > > So I had to add TYPE_CODE_DECFLOAT to the arguments passed via XMM regi= ster, > > but I had to remove it from the values returned via XMM0 register. > > > I won't pretend I cross-checked all of this with the ABI documentation, > but that looks good to me.=C2=A0 If you say the tests now pass, that give= s me > enough confidence, so please go ahead and merge. Pushed, thanks. Hannes