From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14573 invoked by alias); 7 Sep 2006 14:20:51 -0000 Received: (qmail 14551 invoked from network); 7 Sep 2006 14:20:39 -0000 Received: from unknown (80.67.18.14) by sourceware.org with QMTP; 7 Sep 2006 14:20:39 -0000 Received: (qmail 15586 invoked from network); 7 Sep 2006 14:20:38 -0000 Received: from unknown (HELO ibox.ronetix.at) (301615@[80.109.6.193]) (envelope-sender ) by smtprelay02.ispgateway.de (qmail-ldap-1.03) with AES256-SHA encrypted SMTP for ; 7 Sep 2006 14:20:38 -0000 Received: from [192.168.1.4] (mbox_cipe [192.168.1.4]) by ibox.ronetix.at (8.12.8/8.12.8) with ESMTP id k87EKZkN018742; Thu, 7 Sep 2006 16:20:36 +0200 Message-ID: <45002AB3.7090402@ronetix.at> Date: Thu, 07 Sep 2006 14:20:00 -0000 From: Ilko Iliev User-Agent: Thunderbird 1.5.0.5 (X11/20060719) MIME-Version: 1.0 To: Vladimir Prus CC: gdb-patches@sources.redhat.com Subject: "Transfer rate" patch References: <44FD2640.7080605@ronetix.at> In-Reply-To: Content-Type: multipart/mixed; boundary="------------050801070301080704040701" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-09/txt/msg00027.txt.bz2 This is a multi-part message in MIME format. --------------050801070301080704040701 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 2153 Hi, The corrected patch again - the output is in "KBytes/sec" or "bytes/sec". The ChangeLog file is updated too. I changed to "KBytes/sec" because of our and other fast JTAG Emulators. regards, Ilko Iliev Ronetix - JTAG Emulators and Flash Programmers www.ronetix.at Vladimir Prus wrote: > Ilko Iliev wrote: > > >> "Transfer rate" patch >> From: >> Ilko Iliev >> Date: >> Tuesday 05 September 2006 11:24:48 >> Groups: >> gmane.comp.gdb.patches >> Hi, >> >> I found a small bug by the calculating of the transfer rate at the >> "load" command - if the download image size or the download speed is >> higher then occurs overflow and the printed information is wrong. >> >> I attached a patch for this problem. >> >> >> regards, >> Ilko Iliev >> www.ronetix.at >> gdb_download_speed.patch >> --- symfile.c.orig 2006-08-31 15:29:12.000000000 +0200 >> +++ symfile.c 2006-08-31 15:47:28.000000000 +0200 >> @@ -1769,14 +1769,14 @@ >> ui_out_text (uiout, "Transfer rate: "); >> if (time_count > 0) >> { >> - ui_out_field_fmt (uiout, "transfer-rate", "%lu", >> - 1000 * (data_count * 8) / time_count); >> - ui_out_text (uiout, " bits/sec"); >> + ui_out_field_fmt (uiout, "transfer-rate", "%lu", >> + (unsigned long)((((unsigned long >> long)data_count)*1000)/time_count)/1024); + ui_out_text (uiout, " >> Kbytes/sec"); } >> > > I am not sure about motivation to switch to "Kbytes/sec" -- I've seen a > target that does 700 *bytes* per second, so your code will just print '0' > in that case -- is that intended? > > >> else >> { >> - ui_out_field_fmt (uiout, "transferred-bits", "%lu", (data_count * >> 8)); - ui_out_text (uiout, " bits in <1 sec"); >> + ui_out_field_fmt (uiout, "transferred-bits", "%lu", data_count); >> + ui_out_text (uiout, " bytes in <1 sec"); >> > > You've changed the code to output the number of bytes and changes the text > to read "bytes" the the name of output field is still 'transferred-bits'. > I'm not sure this matters (maybe in MI mode), but in any way, you should > adjust that. > > > - Volodya > > --------------050801070301080704040701 Content-Type: text/plain; name="gdb_download_speed.patch" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="gdb_download_speed.patch" Content-length: 2066 LS0tIENoYW5nZUxvZy5vcmlnCTIwMDYtMDktMDcgMTU6MjM6MTkuMDAwMDAw MDAwICswMjAwCisrKyBDaGFuZ2VMb2cJMjAwNi0wOS0wNyAxNToyNzo0Ni4w MDAwMDAwMDAgKzAyMDAKQEAgLTEsMyArMSw4IEBACisyMDA2LTA5LTA3ICBJ bGtvIElsaWV2IDxpbGlldkByb25ldGl4LmF0PgorCisJKiBzeW1maWxlLmMg KHByaW50X3RyYW5zZmVyX3BlcmZvcm1hbmNlKTogRml4IG92ZXJmbG93IHBy b2JsZW0KKyAgICAgICAgYW5kIGNoYW5nZSBiaXRzL3NlYyB0byBLQnl0ZXMv c2VjIG9yIGJ5dGVzL3NlYworCiAyMDA2LTA4LTI4ICBESiBEZWxvcmllICA8 ZGpAcmVkaGF0LmNvbT4KIAogCSogbTMyYy10ZGVwLmMgKG0zMmNfZGVjb2Rl X3NyY2Rlc3Q0KTogSW5pdGlhbGl6ZSBmaWVsZHMgaW4gc2QKCgoKLS0tIHN5 bWZpbGUuYy5vcmlnCTIwMDYtMDgtMzEgMTU6Mjk6MTIuMDAwMDAwMDAwICsw MjAwCisrKyBzeW1maWxlLmMJMjAwNi0wOS0wNyAxNToxOTo0NS4wMDAwMDAw MDAgKzAyMDAKQEAgLTE3NjksMTQgKzE3NjksMjMgQEAKICAgdWlfb3V0X3Rl eHQgKHVpb3V0LCAiVHJhbnNmZXIgcmF0ZTogIik7CiAgIGlmICh0aW1lX2Nv dW50ID4gMCkKICAgICB7Ci0gICAgICB1aV9vdXRfZmllbGRfZm10ICh1aW91 dCwgInRyYW5zZmVyLXJhdGUiLCAiJWx1IiwKLQkJCTEwMDAgKiAoZGF0YV9j b3VudCAqIDgpIC8gdGltZV9jb3VudCk7Ci0gICAgICB1aV9vdXRfdGV4dCAo dWlvdXQsICIgYml0cy9zZWMiKTsKKyAgICAgIGlmICggZGF0YV9jb3VudCA8 IDEwMjQgKQorICAgICAgICB7CisgICAgICAgICAgdWlfb3V0X2ZpZWxkX2Zt dCAodWlvdXQsICJ0cmFuc2Zlci1yYXRlIiwgIiVsdSIsCisgICAgICAgICAg ICAodW5zaWduZWQgbG9uZykoKCgodW5zaWduZWQgbG9uZyBsb25nKWRhdGFf Y291bnQpICogMTAwMCkgLyB0aW1lX2NvdW50KSk7CisgICAgICAgICAgdWlf b3V0X3RleHQgKHVpb3V0LCAiIGJ5dGVzL3NlYyIpOworICAgICAgICB9Cisg ICAgICBlbHNlCisgICAgICAgIHsKKyAgICAgICAgICB1aV9vdXRfZmllbGRf Zm10ICh1aW91dCwgInRyYW5zZmVyLXJhdGUiLCAiJWx1IiwgCisJICAgICh1 bnNpZ25lZCBsb25nKSgoKCh1bnNpZ25lZCBsb25nIGxvbmcpZGF0YV9jb3Vu dCkgKiAxMDAwKSAvIHRpbWVfY291bnQpIC8gMTAyNCk7CisgICAgICAgICAg dWlfb3V0X3RleHQgKHVpb3V0LCAiIEtieXRlcy9zZWMiKTsKKyAgICAgICAg fQogICAgIH0KICAgZWxzZQogICAgIHsKLSAgICAgIHVpX291dF9maWVsZF9m bXQgKHVpb3V0LCAidHJhbnNmZXJyZWQtYml0cyIsICIlbHUiLCAoZGF0YV9j b3VudCAqIDgpKTsKLSAgICAgIHVpX291dF90ZXh0ICh1aW91dCwgIiBiaXRz IGluIDwxIHNlYyIpOworICAgICAgdWlfb3V0X2ZpZWxkX2ZtdCAodWlvdXQs ICJ0cmFuc2ZlcnJlZC1ieXRlcyIsICIlbHUiLCBkYXRhX2NvdW50KTsKKyAg ICAgIHVpX291dF90ZXh0ICh1aW91dCwgIiBieXRlcyBpbiA8MSBzZWMiKTsK ICAgICB9CiAgIGlmICh3cml0ZV9jb3VudCA+IDApCiAgICAgewo= --------------050801070301080704040701--