From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id srrRG9wWqGovWQwAWB0awg (envelope-from ) for ; Mon, 14 Sep 2026 11:46:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1789400796; bh=G5ol4akedYqPqdrr1TAmQ04fmYoFnFY0xXAizszDf68=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=caF2vel+zBHUP4jo++KSFsw3PqU0JkgVjnpCqLKYGYGG67Ntu0nHfMV6UieJVXu00 XvblBuA5d9DQfmDSAjJMYtsRYt5PKsvJmPEiZrtbcxLvd4Ar7a0UXfyVzSy1LynKZq mtDH136GmwdZlj3d1xtz+zvFXCz+/UFDEYLV2xQg= Received: by simark.ca (Postfix, from userid 112) id 608FC1E066; Mon, 14 Sep 2026 11:46:36 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=MfR/FJvV; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E16081E01F for ; Mon, 14 Sep 2026 11:46:35 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8651E4B99F66 for ; Mon, 14 Sep 2026 15:46:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8651E4B99F66 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=MfR/FJvV Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id DB0394B9DB57 for ; Mon, 14 Sep 2026 15:46:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DB0394B9DB57 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DB0394B9DB57 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789400772; cv=none; b=UcbwfH/qfrFrWHygLXYqLY8wUjF3JsmpE/pcNDJnc93PJa9YW+fSJKtmdLHOdd6ePLqVbbCT7CkJ4aH/77SmItGkmupB86V3WwIUqBK+B1MQUZYHuHiaiyzxsSBzoRUHgXu+vGCAqpny7c0Pc9lxM6VM5AwbyW5oICoKnpIX4OE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789400772; c=relaxed/simple; bh=G5ol4akedYqPqdrr1TAmQ04fmYoFnFY0xXAizszDf68=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=oQzyUJMhBeSQnYEPbdhRPiSv829OmoY5/3A6rrdtTe8pF4AMLXOgjKoADjFLH/sc/qbzPnsQTHwoJfj++tZ2bDRKkMbjPLk8h4ry5ksohXAmj2mopOowPrSE91UPUStxeCp3bXA6bOPJ9paLYsj58YocvMUsLv7Fp7C7Ho9mwK0= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=MfR/FJvV DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DB0394B9DB57 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1789400771; bh=G5ol4akedYqPqdrr1TAmQ04fmYoFnFY0xXAizszDf68=; h=Date:Subject:To:References:From:In-Reply-To:From; b=MfR/FJvVbWugAIZ2jGHnqqgTWsFLvY46J9bJYRhYk7Et6MFOqJ2A6RKcq+7orSgZa rgsTqYYCM6hl8KAHghY8faUt/G02IB70b305MxpW8JBeY4AaLVSBXB1BB5ZeFS/s4e /ZqLPXJbvHxPzFmG+SMMtqatF7WVqM1Xv8b7Iv1I= Received: by simark.ca (Postfix) id D4D8C1E01F; Mon, 14 Sep 2026 11:46:10 -0400 (EDT) Message-ID: <44ab10fa-d372-49fa-98d1-7087840e1d93@simark.ca> Date: Mon, 14 Sep 2026 11:46:10 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] Use gdbpy_borrowed_ref when creating events To: Tom Tromey , gdb-patches@sourceware.org References: <20260808-python-safety-events-simple-v1-0-132aea40c801@tromey.com> <20260808-python-safety-events-simple-v1-3-132aea40c801@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20260808-python-safety-events-simple-v1-3-132aea40c801@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/8/26 5:47 PM, Tom Tromey wrote: > diff --git a/gdb/python/py-threadevent.c b/gdb/python/py-threadevent.c > index 9b0a963d0ba..a4a0c16dffc 100644 > --- a/gdb/python/py-threadevent.c > +++ b/gdb/python/py-threadevent.c > @@ -37,7 +37,7 @@ py_get_event_thread (ptid_t ptid) > } > > gdbpy_ref<> > -create_thread_event_object (PyTypeObject *py_type, PyObject *thread) > +create_thread_event_object (PyTypeObject *py_type, gdbpy_borrowed_ref<> thread) > { > gdb_assert (thread != NULL); You can remove the assert since THREAD can't contain nullptr. Simon