From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21550 invoked by alias); 21 Jan 2019 17:09:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21527 invoked by uid 89); 21 Jan 2019 17:09:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,MIME_BASE64_BLANKS,SPF_PASS autolearn=ham version=3.3.2 spammy=pm, simon, nevertheless, Simon X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 21 Jan 2019 17:09:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/relaxed; q=dns/txt; i=@ericsson.com; t=1548090564; x=1550682564; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=m76aQ/c9xCFNfacwMRZYeCMRd51f7+ElfL4ucONensI=; b=O/h7210otz4DPslfI619RvYsuBm44pbEDKZCpfho5woT6VdI8VKP/nTb4LRt1q6V bLO1Hcw858e72RikQQRE6vfOv6XTTqa0dkwBeUzXZgZvNBN6hV63vxNRjnvLNN+w ET9vMR7MzovB5m7UVLPCTs0xcLFpqCsmCfhatFm+MvE=; Received: from ESESSMB501.ericsson.se (Unknown_Domain [153.88.183.119]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 99.1C.01583.4CCF54C5; Mon, 21 Jan 2019 18:09:24 +0100 (CET) Received: from ESESSMB502.ericsson.se (153.88.183.163) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Mon, 21 Jan 2019 18:09:24 +0100 Received: from NAM05-BY2-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB502.ericsson.se (153.88.183.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Mon, 21 Jan 2019 18:09:24 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m76aQ/c9xCFNfacwMRZYeCMRd51f7+ElfL4ucONensI=; b=gb4TimShahJALdrJuP3Y3gbOs1sVi6u9Boy7iVa/Rq9bKuSBJ6dYoh9RMVFGtBVYpSbMRFHZ2jmA7/yIv8nSGz/P3SZ0/Ng6bFdkXnm2tw/tlgLDTbmEszC10LBCnoHxM/RdDgAHNsTh3wyWB8uO2UPhibZO0VNuugQJnKJ4l0c= Received: from BYAPR15MB2390.namprd15.prod.outlook.com (52.135.198.30) by BYAPR15MB2343.namprd15.prod.outlook.com (52.135.197.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1516.18; Mon, 21 Jan 2019 17:09:21 +0000 Received: from BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::a4b4:ea6a:6321:191e]) by BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::a4b4:ea6a:6321:191e%4]) with mapi id 15.20.1516.025; Mon, 21 Jan 2019 17:09:21 +0000 From: Simon Marchi To: Eli Zaretskii CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH v2] Fix MI output for multi-location breakpoints Date: Mon, 21 Jan 2019 17:09:00 -0000 Message-ID: <44a5cfcc-d98e-fd14-ff47-755e218d76d0@ericsson.com> References: <20190118195659.23335-1-simon.marchi@ericsson.com> <83y37hbpwj.fsf@gnu.org> In-Reply-To: <83y37hbpwj.fsf@gnu.org> authentication-results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 Return-Path: simon.marchi@ericsson.com X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00452.txt.bz2 T24gMjAxOS0wMS0xOCA0OjQ2IHAubS4sIEVsaSBaYXJldHNraWkgd3JvdGU6 DQo+PiBGcm9tOiBTaW1vbiBNYXJjaGkgPHNpbW9uLm1hcmNoaUBlcmljc3Nv bi5jb20+DQo+PiBDQzogU2ltb24gTWFyY2hpIDxzaW1vbi5tYXJjaGlAZXJp Y3Nzb24uY29tPg0KPj4gRGF0ZTogRnJpLCAxOCBKYW4gMjAxOSAxOTo1Nzox MSArMDAwMA0KPj4NCj4+ICtUaGUgZm9sbG93aW5nIGNvbW1hbmRzIGNhbiBi ZSB1c2VkIHRvIHNlbGVjdGl2ZWx5IGVuYWJsZSBiZWhhdmlvcnMgZnJvbSBh DQo+PiArbmV3ZXIgTUkgdmVyc2lvbi4gIFRoZXkgY2FuIGJlIHVzZWZ1bCBp ZiB5b3Ugd2FudCB0byB0YWtlIGFkdmFudGFnZSBvZiBmZWF0dXJlDQo+PiAr b3IgYnVnIGZpeCBvbmx5IGF2YWlsYWJsZSBpbiBhIG1vcmUgcmVjZW50IE1J IHZlcnNpb24gdGhhbiB3aGF0IHlvdSBhcmUgdXNpbmcsDQo+PiArYnV0IGNh bid0IHlldCBtaWdyYXRlIHRvIHRoYXQgdmVyc2lvbiBmb3Igc29tZSByZWFz b24uDQo+PiArDQo+PiArQHRhYmxlIEBjb2RlDQo+PiArDQo+PiArQGl0ZW0g LWZpeC1tdWx0aS1sb2NhdGlvbi1icmVha3BvaW50LW91dHB1dA0KPj4gK1Vz ZSB0aGUgb3V0cHV0IGZvciBtdWx0aS1sb2NhdGlvbiBicmVha3BvaW50cyB3 aGljaCB3YXMgaW50cm9kdWNlZCBieSBNSSAzLg0KPj4gK1RoaXMgaGFzIG5v IGVmZmVjdCB3aGVuIHVzaW5nIE1JIHZlcnNpb24gMyBvciBsYXRlci4NCj4g DQo+IEkgbmVlZGVkIHRvIHJlYWQgdGhpcyB0ZXh0IGFuZCB0aGUgb25lIGlu IE5FV1Mgc2V2ZXJhbCB0aW1lcyBiZWZvcmUgSQ0KPiBmaWd1cmVkIG91dCB3 aGF0IGlzIG1lYW50IGhlcmUuICBIb3cgYWJvdXQgdGhpcyBhbHRlcm5hdGl2 ZSBpbnN0ZWFkOg0KPiANCj4gICBJZiB5b3VyIGZyb250IGVuZCBjYW5ub3Qg eWV0IG1pZ3JhdGUgdG8gYSBtb3JlIHJlY2VudCB2ZXJzaW9uIG9mIHRoZQ0K PiAgIE1JIHByb3RvY29sLCB5b3UgY2FuIG5ldmVydGhlbGVzcyBzZWxlY3Rp dmVseSBlbmFibGUgc3BlY2lmaWMgZmVhdHVyZXMNCj4gICBhdmFpbGFibGUg aW4gdGhvc2UgcmVjZW50IE1JIHZlcnNpb25zLCB1c2luZyB0aGUgZm9sbG93 aW5nIGNvbW1hbmRzOg0KPiANCj4gICBAdGFibGUgQGNvZGUNCj4gDQo+ICAg QGl0ZW0gLWZpeC1tdWx0aS1sb2NhdGlvbi1icmVha3BvaW50LW91dHB1dA0K PiAgIFVzZSB0aGUgb3V0cHV0IGZvciBtdWx0aS1sb2NhdGlvbiBicmVha3Bv aW50cyB3aGljaCB3YXMgaW50cm9kdWNlZCBieQ0KPiAgIE1JIDMsIGV2ZW4g d2hlbiB1c2luZyBNSSB2ZXJzaW9ucyAyIG9yIDEuICBUaGlzIGNvbW1hbmQg aGFzIG5vDQo+ICAgZWZmZWN0IHdoZW4gdXNpbmcgTUkgdmVyc2lvbiAzIG9y IGxhdGVyLg0KPiANCj4gICBAZW5kIEB0YWJsZQ0KDQpUaGFua3MsIEkgYWRv cHRlZCB0aGlzIHdvcmRpbmcuDQoNCj4gT3RoZXJ3aXNlLCB0aGUgZG9jdW1l bnRhdGlvbiBwYXJ0cyBhcmUgT0suDQoNClRoYW5rcyBmb3IgdGhlIHJldmll d3MuDQoNCkkgYW0gc3RpbGwgb3BlbiB0byBjb21tZW50cyBhYm91dCB0aGUg Y29kZSBwYXJ0cy4gIEluIGFueSBjYXNlLCB0aGUgcGF0Y2ggd2lsbA0KcmVt YWluIHVwIGZvciByZXZpZXcgYXQgbGVhc3QgdW50aWwgdGhlIEdEQiA4LjMg YnJhbmNoIGlzIGNyZWF0ZWQuDQoNClNpbW9uDQoNCg0K >From gdb-patches-return-153563-listarch-gdb-patches=sources.redhat.com@sourceware.org Mon Jan 21 17:28:48 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 44847 invoked by alias); 21 Jan 2019 17:28:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 44834 invoked by uid 89); 21 Jan 2019 17:28:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=hear X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 21 Jan 2019 17:28:46 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7A5078AE52; Mon, 21 Jan 2019 17:28:45 +0000 (UTC) Received: from blade.nx (unknown [10.36.118.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4489460C78; Mon, 21 Jan 2019 17:28:45 +0000 (UTC) Received: by blade.nx (Postfix, from userid 1000) id 675C4816CC36; Mon, 21 Jan 2019 17:28:44 +0000 (GMT) Date: Mon, 21 Jan 2019 17:28:00 -0000 From: Gary Benson To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Remove duplicate or commented-out #includes Message-ID: <20190121172843.GA7007@blade.nx> References: <20190119213007.23712-1-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190119213007.23712-1-tom@tromey.com> X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00453.txt.bz2 Content-length: 679 Tom Tromey wrote: > I wrote a little script to detect duplicate or commented-out > #includes and ran it on gdb. This patch is the result. Tested > by rebuilding. Looks good to me :) I did something similar a few years back, though possibly only for system headers, or for just the ones in common-defs.h. So obviously I approve! > It would be possible to sort #includes, or maybe run > include-what-you-use on gdb, but I haven't tried that. I'd be > interested to hear if you think this would be worthwhile, thoug. I'd consider it worthwhile. I'd really like sorted #includes. Some files have random whitespace in the list too, that maybe made sense once. Cheers, Gary