From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29832 invoked by alias); 24 Jul 2006 20:40:28 -0000 Received: (qmail 29769 invoked by uid 22791); 24 Jul 2006 20:40:25 -0000 X-Spam-Check-By: sourceware.org Received: from mail.oarcorp.com (HELO mail.oarcorp.com) (216.186.189.5) by sourceware.org (qpsmtpd/0.31) with SMTP; Mon, 24 Jul 2006 20:40:21 +0000 Received: (qmail 28707 invoked by uid 507); 24 Jul 2006 20:40:19 -0000 Received: from 192.168.1.3 by mail.oarcorp.com (envelope-from , uid 501) with qmail-scanner-1.25st (spamassassin: 3.1.1. perlscan: 1.25st. Clear:RC:1(192.168.1.3):. Processed in 0.051731 secs); 24 Jul 2006 20:40:19 -0000 X-Qmail-Scanner-Mail-From: joel.sherrill@oarcorp.com via mail.oarcorp.com X-Qmail-Scanner: 1.25st (Clear:RC:1(192.168.1.3):. Processed in 0.051731 secs Process 28699) Received: from unknown (HELO ?192.168.1.3?) (192.168.1.3) by mail.oarcorp.com with SMTP; 24 Jul 2006 20:40:19 -0000 Message-ID: <44C53033.3070404@oarcorp.com> Date: Mon, 24 Jul 2006 20:40:00 -0000 From: Joel Sherrill User-Agent: Mozilla Thunderbird 1.0.7-1.1.fc3 (X11/20050929) MIME-Version: 1.0 To: Daniel Jacobowitz CC: gdb-patches@sourceware.org Subject: Re: GDB 6.5 RTEMS patch References: <44B6AFEF.6050903@oarcorp.com> <20060724202837.GE15759@nevyn.them.org> In-Reply-To: <20060724202837.GE15759@nevyn.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00357.txt.bz2 Daniel Jacobowitz wrote: >On Thu, Jul 13, 2006 at 03:41:19PM -0500, Joel Sherrill wrote: > > >>diff -uNr /home/joel/tools-original/gdb-6.5/bfd/sysdep.h gdb-6.5/bfd/sysdep.h >>--- /home/joel/tools-original/gdb-6.5/bfd/sysdep.h 2005-05-05 13:51:14.000000000 -0500 >>+++ gdb-6.5/bfd/sysdep.h 2006-07-13 10:00:00.000000000 -0500 >>@@ -135,7 +135,7 @@ >> #endif >> >> #if !HAVE_DECL_STRSTR >>-extern char *strstr (); >>+/* extern char *strstr (); */ >> #endif >> >> #ifdef HAVE_FTELLO >> >> > >What's this for? Shouldn't be necessary, of course. > > > Yep. That's looks like junk leftover. I can tell you what used to be there. :) We build RPMs on RH73 so all subsequent RH and Fedora Core versions can use them. There are a lot of gcc versions installed into /opt in that environment and some gcc version wouldn't build gdb and failed at that line for reasons I could never explain. That is a leftover hack that should be ignored. I am sorry for \ leaving it in there. >>diff -uNr /home/joel/tools-original/gdb-6.5/sim/erc32/exec.c gdb-6.5/sim/erc32/exec.c >>--- /home/joel/tools-original/gdb-6.5/sim/erc32/exec.c 2005-03-07 05:09:05.000000000 -0600 >>+++ gdb-6.5/sim/erc32/exec.c 2006-07-13 10:00:00.000000000 -0500 >>@@ -1713,7 +1713,7 @@ >> sregs->fdp[rs2 | 1] = sregs->fs[rs2 & ~1]; >> sregs->fdp[rs2 & ~1] = sregs->fs[rs2 | 1]; >> default: >>- ; >>+ break; >> } >> #endif >> >>@@ -1886,7 +1886,7 @@ >> sregs->fs[rd & ~1] = sregs->fdp[rd | 1]; >> sregs->fs[rd | 1] = sregs->fdp[rd & ~1]; >> default: >>- ; >>+ break; >> } >> #endif >> if (sregs->fpstate == FP_EXC_PE) { >> >> > >Are you sure these are still needed? I thought that "default: }" was >bad, but "default: ;}" was fine. > > Checking all the gcc's I have installed, that does seem to be the case. Adding the ";" let's gcc know default wasn't a label. But why wouldn't you want an explicit break? --joel