Eli Zaretskii wrote:
>> -  if (file == NULL)
>> +  if (file == NULL || strlen (file) == 0)
>                          ^^^^^^^^^^^^^^^^^^
> Nitpicking: isn't it better to use *file == 0 instead?

Ok.

>>        error (_("source command requires pathname of file to source."));
> 
> Another nit: the GNU project does not like to use ``pathname''; please
> use ``file name'' (yes, two words) instead.

This is the original text. I have taken the opportunity to change it.

>> +Optional -v switch (before the filename) causes each command in\n\
>> +FILE to be echo as it is executed.\n\
>         ^^^^^^^^^^
> You meant "to be echoed", right?

Quite so.

>>  Note that the file \"%s\" is read automatically in this way\n\
>>  when gdb is started."), gdbinit);
> 
> I think "gdb" should be up-cased.

Again, this is the original text, but I have changed it as suggested.

>> +If you need to debug user-defined commands or sourced files you may find it
>> +useful to enable command tracing.
> 
> This paragraph could benefit from two small changes:
> 
>  . enclose "command tracing" in the above sentence in @dfn{}, to make
>    it stand out--this is a new term you are introducing here
>  . add "@cindex command tracing" before the paragraph

Fixed.

> Otherwise, the patch is okay with me.  Thanks.

Thanks, I have committed the attached.

I suppose I ought to write a test case for this. Is there any existing 
test file where this sort of thing belongs, or should I just create a 
new file?

Andrew