Re: [RFA] New substitute-path commands

Eli Zaretskii
2006-07-08T12:19:41Z

> Date: Fri, 7 Jul 2006 12:12:03 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sources.redhat.com
>
> Thanks for your review (and also the effort you made in providing a
> description of what a substitution rule is, much appreciated). I have
> updated the source as per your comments, as well as reworked the
> documentation to include your ideas.

Thanks, I'm almost happy now.

> I also took the time to include a
> small explaination of how this new functionality differs slightly from
> the "dir" command. It's not necessary since the explaination can be
> deduced from the rest of the documentation, but might make it easier to
> figure this out.

I think it's a good addition, thanks.

> +directory between compilation and debugging. @value{GDBN} does a simple
> +string replacement of the first occurrence of @var{from} with @var{to}
> +in the directory part of the source file name, and uses the result
> +instead of the original file name to look up the sources.

I suggested to have this text after the command description. In that
context, @var{from} and @var{to} refer to the command's arguments.
But you moved the description higher in the text, which made those
reference dangling. So this needs to be reworded in some way.

> +However, @code{set substitute-path} is also more than just a shortcut

This However is redundant here, I think.