From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12988 invoked by alias); 19 Jun 2006 18:50:24 -0000 Received: (qmail 12980 invoked by uid 22791); 19 Jun 2006 18:50:24 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 19 Jun 2006 18:50:22 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k5JIoLnT015724; Mon, 19 Jun 2006 14:50:21 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx1.corp.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k5JIoEkS014332; Mon, 19 Jun 2006 14:50:15 -0400 Received: from [172.16.24.50] (bluegiant.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id k5JIoCoi013659; Mon, 19 Jun 2006 14:50:13 -0400 Message-ID: <4496F1E3.10000@redhat.com> Date: Mon, 19 Jun 2006 18:50:00 -0000 From: Michael Snyder User-Agent: Mozilla Thunderbird 1.0.7-1.4.1 (X11/20050929) MIME-Version: 1.0 To: Joel Brobecker CC: GDB Patches , Fred Fish Subject: Re: [RFA] mips, floating point arg passing References: <447E279C.7020804@redhat.com> <20060609180543.GA860@adacore.com> In-Reply-To: <20060609180543.GA860@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00275.txt.bz2 Joel Brobecker wrote: > Hello Michael, > > >>GDB is causing SIGFPE on target boards that have a FPU, >>when compiled for a 32 bit ABI. > > > I've only worked with the n32 ABI so far, so I'm not familiar with > the EABI nor o32 ABI. But I presume you know what you're talking > about :-). > > >>2006-05-31 Michael Snyder >> >> * mips-tdep.c (mips_eabi_push_dummy_call): For 32 bit ABI, to >> decide how many registers it takes to pass a floating point >> argument, what matters is the size of a floating point register >> (not the size of a general purpose register). >> (mips_o32_push_dummy_call): Ditto. > > > I'm not sure I really have the knowledge to approve but Daniel asked > for help in that department, so I'll give it a try. > > This patch seems pretty logical to me, so go ahead and commit. Is it > possible to run the testsuite on either o32, or on a target board? I did -- but it was quite some time ago now, and I couldn't really put my hands on them. I'm pretty sure they got better. Certainly they didn't get worse. Committing.