From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12482 invoked by alias); 13 Jun 2006 08:31:31 -0000 Received: (qmail 12474 invoked by uid 22791); 13 Jun 2006 08:31:31 -0000 X-Spam-Check-By: sourceware.org Received: from potter.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 13 Jun 2006 08:31:29 +0000 Received: (qmail 19965 invoked from network); 13 Jun 2006 08:31:27 -0000 Received: from unknown (HELO ?192.168.189.145?) (nathan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 13 Jun 2006 08:31:27 -0000 Message-ID: <448E77B3.8060101@codesourcery.com> Date: Tue, 13 Jun 2006 08:31:00 -0000 From: Nathan Sidwell User-Agent: Mozilla Thunderbird 1.0.8 (X11/20060502) MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: Add system(NULL) to fileio References: <4489D824.40605@codesourcery.com> <20060612121124.GA19317@calimero.vinschen.de> In-Reply-To: <20060612121124.GA19317@calimero.vinschen.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00173.txt.bz2 Corinna Vinschen wrote: > > Wouldn't it be better to add a short comment here explaining the !length > case, something along the lines of "A zero length indicates a NULL > argument to system(3) ... handled according to POSIX (check if shell > exists) even if the system call hasn't been allowed by the user"? I'll add such a comment, thanks for the review. nathan -- Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery nathan@codesourcery.com :: http://www.planetfall.pwp.blueyonder.co.uk