From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32344 invoked by alias); 12 Jun 2006 19:26:36 -0000 Received: (qmail 32335 invoked by uid 22791); 12 Jun 2006 19:26:36 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 12 Jun 2006 19:26:34 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k5CJQWhA004409; Mon, 12 Jun 2006 15:26:32 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx1.corp.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k5CJQVKx031773; Mon, 12 Jun 2006 15:26:31 -0400 Received: from [172.16.24.50] (bluegiant.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id k5CJQToi002392; Mon, 12 Jun 2006 15:26:30 -0400 Message-ID: <448DBFE5.9040309@redhat.com> Date: Mon, 12 Jun 2006 19:26:00 -0000 From: Michael Snyder User-Agent: Mozilla Thunderbird 1.0.7-1.4.1 (X11/20050929) MIME-Version: 1.0 To: Joel Brobecker CC: GDB Patches , Fred Fish Subject: Re: [RFA] replace stub fn mips_eabi_return_value References: <447E2CF3.4070102@redhat.com> <20060609184026.GC860@adacore.com> In-Reply-To: <20060609184026.GC860@adacore.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00160.txt.bz2 Joel Brobecker wrote: >>2006-05-31 Michael Snyder >> >> * mips-tdep.c (mips_eabi_return_value): Replace stub that always >> returned RETURN_VALUE_STRUCT_CONVENTION with a real function. > > > This looks OK to me. Just make sure to remove the two commented out > lines of code in the last "for" block. Will do, but now that you mention it -- that comment was sort of a reminder to myself that I should ping Fred about this issue. Fred, your similar code for o64 also makes use of register_size. I don't at the moment remember what the issue was, but I did run into problems that suggested to me that stack_argsize was a better choice -- and the change did improve things. Any thoughts? >>! for (offset = 0; >>! offset < TYPE_LENGTH (type); >>! /* offset += register_size (gdbarch, regnum), regnum++) */ >>! offset += mips_stack_argsize (gdbarch), regnum++) >>! { >>! /* xfer = register_size (gdbarch, regnum); */ > >