From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17151 invoked by alias); 8 Jun 2006 19:16:44 -0000 Received: (qmail 17139 invoked by uid 22791); 8 Jun 2006 19:16:44 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 08 Jun 2006 19:16:42 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k58JGeHT014324; Thu, 8 Jun 2006 15:16:40 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx1.corp.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k58JGTBx003795; Thu, 8 Jun 2006 15:16:30 -0400 Received: from [172.16.24.50] (bluegiant.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id k58JGR71001918; Thu, 8 Jun 2006 15:16:28 -0400 Message-ID: <4488778B.1080800@redhat.com> Date: Thu, 08 Jun 2006 19:16:00 -0000 From: Michael Snyder User-Agent: Mozilla Thunderbird 1.0.7-1.4.1 (X11/20050929) MIME-Version: 1.0 To: GDB Patches CC: Joel Brobecker , Fred Fish Subject: Re: [RFA] mips, floating point arg passing References: <447E279C.7020804@redhat.com> In-Reply-To: <447E279C.7020804@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00077.txt.bz2 Ping? Michael Snyder wrote: > GDB is causing SIGFPE on target boards that have a FPU, > when compiled for a 32 bit ABI. > > > ------------------------------------------------------------------------ > > 2006-05-31 Michael Snyder > > * mips-tdep.c (mips_eabi_push_dummy_call): For 32 bit ABI, to > decide how many registers it takes to pass a floating point > argument, what matters is the size of a floating point register > (not the size of a general purpose register). > (mips_o32_push_dummy_call): Ditto. > > Index: mips-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/mips-tdep.c,v > retrieving revision 1.393 > diff -p -r1.393 mips-tdep.c > *** mips-tdep.c 31 May 2006 23:15:50 -0000 1.393 > --- mips-tdep.c 31 May 2006 23:28:59 -0000 > *************** mips_eabi_push_dummy_call (struct gdbarc > *** 2494,2500 **** > if (fp_register_arg_p (typecode, arg_type) > && float_argreg <= MIPS_LAST_FP_ARG_REGNUM) > { > ! if (mips_abi_regsize (gdbarch) < 8 && len == 8) > { > int low_offset = TARGET_BYTE_ORDER == BFD_ENDIAN_BIG ? 4 : 0; > unsigned long regval; > --- 2494,2500 ---- > if (fp_register_arg_p (typecode, arg_type) > && float_argreg <= MIPS_LAST_FP_ARG_REGNUM) > { > ! if (register_size (gdbarch, float_argreg) < 8 && len == 8) > { > int low_offset = TARGET_BYTE_ORDER == BFD_ENDIAN_BIG ? 4 : 0; > unsigned long regval; > *************** mips_o32_push_dummy_call (struct gdbarch > *** 3118,3124 **** > if (fp_register_arg_p (typecode, arg_type) > && float_argreg <= MIPS_LAST_FP_ARG_REGNUM) > { > ! if (mips_abi_regsize (gdbarch) < 8 && len == 8) > { > int low_offset = TARGET_BYTE_ORDER == BFD_ENDIAN_BIG ? 4 : 0; > unsigned long regval; > --- 3118,3124 ---- > if (fp_register_arg_p (typecode, arg_type) > && float_argreg <= MIPS_LAST_FP_ARG_REGNUM) > { > ! if (register_size (gdbarch, float_argreg) < 8 && len == 8) > { > int low_offset = TARGET_BYTE_ORDER == BFD_ENDIAN_BIG ? 4 : 0; > unsigned long regval;