From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16469 invoked by alias); 1 Jun 2006 18:33:42 -0000 Received: (qmail 16458 invoked by uid 22791); 1 Jun 2006 18:33:41 -0000 X-Spam-Check-By: sourceware.org Received: from intranet.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.6) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 01 Jun 2006 18:33:36 +0000 Received: (qmail 31713 invoked from network); 1 Jun 2006 18:33:34 -0000 Received: from unknown (HELO ?192.168.189.145?) (nathan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 1 Jun 2006 18:33:34 -0000 Message-ID: <447F32E2.7010507@codesourcery.com> Date: Thu, 01 Jun 2006 18:33:00 -0000 From: Nathan Sidwell User-Agent: Mozilla Thunderbird 1.0.8 (X11/20060502) MIME-Version: 1.0 CC: Daniel Jacobowitz , Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: patch for invalid hw breakpoints References: <447EE9A8.4050800@codesourcery.com> <20060601172639.GA25709@nevyn.them.org> <447F27BC.6030808@codesourcery.com> In-Reply-To: <447F27BC.6030808@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00007.txt.bz2 Nathan Sidwell wrote: > The remote stub can deal with this, but the functionality detection code > in remote.c cannot. In particular this bit of code in > remote_remove_watchpoint triggers because the just attempted > remote_insert_watchpoint call has now set the support field to > PACKET_DISABLE. one thing that may not be clear from what I said is that this particular stub does not support Z2 packets, so returns an empty response as required by the gdb protocol. If the stub did support Z2 packets, it would have to deal with duplicates. nathan -- Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery nathan@codesourcery.com :: http://www.planetfall.pwp.blueyonder.co.uk