Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Sandra Loosemore <sandra@codesourcery.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: PATCH: copy-edit File-I/O section of manual
Date: Sun, 14 May 2006 03:29:00 -0000	[thread overview]
Message-ID: <446659B7.3040306@codesourcery.com> (raw)
In-Reply-To: <u4pzt69f3.fsf@gnu.org>

Eli Zaretskii wrote:

> Thanks.  However, could you please submit these as two separate
> patches, one that fixes only the spelling and grammar, the other with
> the rest? 

You're basically asking me to throw out the work I did and start over.  I don't 
think I'm motivated enough to want to do that.

 >  I'd like to understand the motivation for moving stuff
> around, for starters.

There were three pieces I moved around.  I moved the separate sections on the 
restrictions on isatty() and system() to the (respective) sections where the 
actual functions are documented, so that all the information is in one place 
instead of split in two different places.  The third piece was the section on 
memory access, which I moved to the "Protocol specific representation of 
datatypes" section.  Again, the motivation was to collect related information in 
one place.

> Also, when you send the patch for spelling and grammar, please try not
> to reformat lines, so that unmodified lines don't appear in the diffs.
> The way you did it (refilling the paragraphs after changing them)
> makes the diffs unnecessarily voluminous and hard to read.

I *did* avoid reformatting lines as much as possible.  However, there were a lot 
of lines that needed some sort of edit or another, even though many of the 
changes were very minor.  Rather than trying to make sense of the line-by-line 
diffs, I suggest that the right way to review this change is to apply them and 
proofread the resulting text.  If you spot additional problems, let me know and 
I can provide a revised patch to address them.

-Sandra



  reply	other threads:[~2006-05-13 22:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-13 14:32 Sandra Loosemore
2006-05-13 19:03 ` Eli Zaretskii
2006-05-14  3:29   ` Sandra Loosemore [this message]
2006-05-14  6:35     ` Eli Zaretskii
2006-05-14 15:01       ` Sandra Loosemore
2006-05-14 15:10         ` Daniel Jacobowitz
2006-05-14 19:44           ` Sandra Loosemore
2006-05-14 22:06             ` Eli Zaretskii
2006-05-15 15:09               ` Sandra Loosemore
2006-05-15 20:44                 ` Eli Zaretskii
2006-05-14 20:15           ` Eli Zaretskii
2006-05-14 20:21             ` Daniel Jacobowitz
2006-05-14 20:12         ` Eli Zaretskii
2006-06-09 19:43 ` Eli Zaretskii
2006-06-10 18:50   ` Sandra Loosemore
2006-06-10 21:34     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=446659B7.3040306@codesourcery.com \
    --to=sandra@codesourcery.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox