From: Michael Snyder <msnyder@redhat.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] problem fetching inferior memory due to breakpoint
Date: Wed, 26 Apr 2006 23:33:00 -0000 [thread overview]
Message-ID: <44500338.4090808@redhat.com> (raw)
In-Reply-To: <20060426222904.GA9745@nevyn.them.org>
Daniel Jacobowitz wrote:
> On Wed, Apr 26, 2006 at 03:18:01PM -0700, Joel Brobecker wrote:
>
>>>Neither, where in win32-nat were you planning to modify? Presumably
>>>you should change the i386 prologue analyzer.
>>
>>Aaahh, not win32-nat, but i386-tdep, in the prologue analyzer.
>>If this is the prefered method, then I think you can expect a patch
>>for tomorrow.
>
>
> I think that's the right fix.
>
You know what might be a good optimization?
Take "breakpoints_inserted" out of infcmd, stick it in breakpoint.c,
and export an access method. It makes no sense for anybody except
breakpoint.c to be keeping track of this anyway.
Then, read_memory_no_bpt can simply check this, and if it's not set,
default to target_read_memory.
next prev parent reply other threads:[~2006-04-26 23:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-26 19:05 Joel Brobecker
2006-04-26 19:19 ` Daniel Jacobowitz
2006-04-26 21:18 ` Joel Brobecker
2006-04-26 21:39 ` Daniel Jacobowitz
2006-04-26 22:18 ` Joel Brobecker
2006-04-26 22:29 ` Daniel Jacobowitz
2006-04-26 23:33 ` Michael Snyder [this message]
2006-04-27 0:42 ` Daniel Jacobowitz
2006-04-27 1:37 ` Michael Snyder
2006-04-27 2:10 ` Daniel Jacobowitz
2006-04-27 0:53 ` Jim Blandy
2006-04-27 20:28 ` Eli Zaretskii
2006-04-27 20:56 ` Joel Brobecker
2006-04-28 5:12 ` Eli Zaretskii
2006-04-28 17:00 ` Joel Brobecker
2006-04-28 17:45 ` Daniel Jacobowitz
2006-04-29 14:14 ` Eli Zaretskii
2006-04-29 14:14 ` Eli Zaretskii
2006-04-29 14:20 ` Daniel Jacobowitz
2006-04-29 14:48 ` Eli Zaretskii
2006-04-29 15:06 ` Daniel Jacobowitz
2006-04-29 15:18 ` Daniel Jacobowitz
2006-04-29 17:10 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44500338.4090808@redhat.com \
--to=msnyder@redhat.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox