From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19876 invoked by alias); 20 Apr 2006 19:09:02 -0000 Received: (qmail 19852 invoked by uid 22791); 20 Apr 2006 19:09:01 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 20 Apr 2006 19:08:57 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k3KJ8s0l011805; Thu, 20 Apr 2006 15:08:54 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx1.corp.redhat.com (8.12.11.20060308/8.11.6) with ESMTP id k3KJ8sQM012527; Thu, 20 Apr 2006 15:08:54 -0400 Received: from [172.16.24.50] (bluegiant.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id k3KJ8qTq015791; Thu, 20 Apr 2006 15:08:53 -0400 Message-ID: <4447DC44.1030508@redhat.com> Date: Thu, 20 Apr 2006 19:09:00 -0000 From: Michael Snyder User-Agent: Mozilla Thunderbird 1.0.7-1.4.1 (X11/20050929) MIME-Version: 1.0 To: Daniel Jacobowitz CC: gdb-patches@sourceware.org Subject: Re: [RFC] New target, Renesas M32C References: <443EBDFB.7090601@redhat.com> <20060420163311.GH11710@nevyn.them.org> In-Reply-To: <20060420163311.GH11710@nevyn.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00290.txt.bz2 Daniel Jacobowitz wrote: > On Thu, Apr 13, 2006 at 02:09:15PM -0700, Michael Snyder wrote: > >>This target architecture has already been added to gcc and binutils. >>Here's the gdb port. > > > I think this is fine. I only skimmed it; the most interesting bits are > the prologue analysis, which I've looked over before. The rest nothing > jumped out at me. Other than that I've only very small comments: > > - Please add it to NEWS as Eli requested. Will do. > - Are you volunteering to maintain this port? If so, please add > a MAINTAINERS entry. If not, I don't want a port added without > a maintainer. Hah! Well, if jimb won't step forward, I guess I'm stuck with it. ;-) > - Instead of this: > > >>+ #if defined (HAVE_STRING_H) >>+ #include >>+ #endif > > > use "gdb_string.h". Will do, thanks. Consider it committed (even though it'll be a few minutes before I actually do so).